Forms locking mechanism

[pbuergi]

Nextcloud (please complete the following information):

• Nextcloud-Version: 31.0.9 Enterprise
• Forms-Version: 5.2.0

Is your feature request related to a problem? Please describe.
When a form is share with edit permission, i allways have to wait 15min to edit the shared form.

Describe the solution you'd like

• Document the edit-share-permission-lock feature
• It should be possible to edit the form immediately after approval (optional)

Describe alternatives you've considered
wait

Additional context
#2737 (comment)
I don't really get the lock feature for forms and i didn't find more info about it.

[Chartman123]

@pbuergi the form owner can always remove a form lock within the settings of the form.

• Document the edit-share-permission-lock feature

If you want you can help us by creating some user facing documentation. This is also already tracked in #2643

• It should be possible to edit the form immediately after approval (optional)

Please explain in detail what you mean with this

[pbuergi]

which setting?

[Chartman123]

If the form is locked, there is a button on top of the settings to unlock it

[pbuergi]

I don't see that.
Could it be that the problem is that an error occurs when I share it? (we use external storage with 0B Quota #2900)

NotPermittedException
Could not create folder "/[user]/files/Forms/43 - Test Formualr"

Sharing the form (with edit perm) still works if i do it several times

[Chartman123]

Do you have a file question in the form? For this to work the owner of the form must be able to create folders. Uploaded files will also be counted against the owner's quota

[pbuergi]

No, just a checkbox question. The error occurs with every form. Also when i have a quota (e.g. 10GB) the error occurs when i share the form.

[znerol]

I'm observing this problem as well. I think the issue is that a form isn't unlocked when leaving the editor. How about unlocking the form whenever the editor is unmounted?

diff --git a/src/views/Create.vue b/src/views/Create.vue
index c2abebcf..31c913d8 100644
--- a/src/views/Create.vue
+++ b/src/views/Create.vue
@@ -392,6 +392,11 @@ export default {
                this.questionRefs = []
        },

+       unmounted() {
+               this.form.lockedUntil = null
+               this.saveFormProperty('lockedUntil')
+       },
+
        mounted() {
                this.fetchFullForm(this.form.id)
                SetWindowTitle(this.formTitle)

[znerol]

Filed PR #3342 which unlocks the form when the user leaves the form editor.

[Chartman123]

a form isn't unlocked when leaving the editor.

Yes, this is how it's designed. Leaving the editor doesn't mean, that the user who currently has locked the form, has finished actions that will obtain a form lock. For example one could be in the results view and link a spreadsheet. Or your in the submit view and open the sidebar to change some form settings.

That's why we've decided to rely on the timeout and the explicit form unlocking.

[znerol]

I witnessed two very confused users last week. It took them quite a while until they figured out a way on how they can work together on a form. At the end, they agreed to just transfer ownership to whomever needs to edit. They sat at a close distance. I cannot imagine how they would have figured out a way to work together when one/both of them were remote.

From my observations, this is a UX issue. I think there needs to be a better way to handle it.

One quick idea: Do not restrict the unlock button to the owner of the form. Instead, also let users unlock the form if they are currently holding the lock.