fs: implement glob natively

Signed-off-by: avivkeller <me@aviv.sh>

Author: avivkeller

.github/workflows/tools.yml

@@ -29,7 +29,6 @@ on:
           - libffi
           - libuv
           - llhttp
-          - minimatch
           - nbytes
           - nixpkgs-unstable
           - nghttp2
@@ -187,14 +186,6 @@ jobs:
               cat temp-output
               tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
               rm temp-output
-          - id: minimatch
-            subsystem: deps
-            label: dependencies
-            run: |
-              ./tools/dep_updaters/update-minimatch.sh > temp-output
-              cat temp-output
-              tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true
-              rm temp-output
           - id: nbytes
             subsystem: deps
             label: dependencies

LICENSE

@@ -2058,65 +2058,6 @@ The externally maintained libraries used by Node.js are:
     CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
   """
 
-- minimatch, located at deps/minimatch, is licensed as follows:
-  """
-    # Blue Oak Model License
-
-    Version 1.0.0
-
-    ## Purpose
-
-    This license gives everyone as much permission to work with
-    this software as possible, while protecting contributors
-    from liability.
-
-    ## Acceptance
-
-    In order to receive this license, you must agree to its
-    rules. The rules of this license are both obligations
-    under that agreement and conditions to your license.
-    You must not do anything with this software that triggers
-    a rule that you cannot or will not follow.
-
-    ## Copyright
-
-    Each contributor licenses you to do everything with this
-    software that would otherwise infringe that contributor's
-    copyright in it.
-
-    ## Notices
-
-    You must ensure that everyone who gets a copy of
-    any part of this software from you, with or without
-    changes, also gets the text of this license or a link to
-    <https://blueoakcouncil.org/license/1.0.0>.
-
-    ## Excuse
-
-    If anyone notifies you in writing that you have not
-    complied with [Notices](#notices), you can keep your
-    license by taking all practical steps to comply within 30
-    days after the notice. If you do not do so, your license
-    ends immediately.
-
-    ## Patent
-
-    Each contributor licenses you to do everything with this
-    software that would otherwise infringe any patent claims
-    they can license or become able to license.
-
-    ## Reliability
-
-    No contributor can revoke this license.
-
-    ## No Liability
-
-    **_As far as the law allows, this software comes as is,
-    without any warranty or condition, and no contributor
-    will be liable to anyone for any damages related to this
-    software or this license, under any kind of legal claim._**
-  """
-
 - npm, located at deps/npm, is licensed as follows:
   """
     The npm application

benchmark/fs/bench-glob-options.js

@@ -0,0 +1,78 @@
+'use strict';
+
+const common = require('../common');
+const {
+  glob,
+  globSync,
+  promises: { glob: globAsync },
+} = require('fs');
+const path = require('path');
+const assert = require('node:assert');
+
+const benchmarkDirectory = path.resolve(__dirname, '..', '..');
+
+const configs = {
+  n: [1e3],
+  dir: ['lib'],
+  pattern: ['**/*.js'],
+  mode: ['sync', 'promise', 'callback'],
+  options: ['none', 'withFileTypes', 'exclude-pattern', 'exclude-callback'],
+};
+
+const bench = common.createBenchmark(main, configs);
+
+function buildOptions(config) {
+  const options = { cwd: path.resolve(benchmarkDirectory, config.dir) };
+  switch (config.options) {
+    case 'none':
+      break;
+    case 'withFileTypes':
+      options.withFileTypes = true;
+      break;
+    case 'exclude-pattern':
+      options.exclude = ['**/internal/**'];
+      break;
+    case 'exclude-callback':
+      // Excludes nothing: measures the per-entry callback overhead alone.
+      options.exclude = () => false;
+      break;
+    default:
+      throw new Error(`Unknown options: ${config.options}`);
+  }
+  return options;
+}
+
+async function main(config) {
+  const { pattern, mode, n } = config;
+  const options = buildOptions(config);
+
+  let noDead;
+  bench.start();
+
+  for (let i = 0; i < n; i++) {
+    switch (mode) {
+      case 'sync':
+        noDead = globSync(pattern, options);
+        break;
+      case 'promise':
+        noDead = await Array.fromAsync(globAsync(pattern, options));
+        break;
+      case 'callback':
+        noDead = await new Promise((resolve, reject) => {
+          glob(pattern, options, (err, matches) => {
+            if (err) {
+              reject(err);
+            } else {
+              resolve(matches);
+            }
+          });
+        });
+        break;
+      default:
+        throw new Error(`Unknown mode: ${mode}`);
+    }
+  }
+
+  bench.end(n);
+  assert.ok(noDead.length > 0);
+}

benchmark/fs/bench-glob.js

@@ -14,46 +14,43 @@ const benchmarkDirectory = path.resolve(__dirname, '..', '..');
 const configs = {
   n: [1e3],
   dir: ['lib'],
-  pattern: ['**/*', '*.js', '**/**.js'],
+  pattern: ['**/*', '*.js', '**/*.js', '**/*.{js,json}'],
   mode: ['sync', 'promise', 'callback'],
-  recursive: ['true', 'false'],
 };
 
 const bench = common.createBenchmark(main, configs);
 
 async function main(config) {
-  const fullPath = path.resolve(benchmarkDirectory, config.dir);
-  const { pattern, recursive, mode } = config;
-  const options = { cwd: fullPath, recursive };
-  const callback = (resolve, reject) => {
-    glob(pattern, options, (err, matches) => {
-      if (err) {
-        reject(err);
-      } else {
-        resolve(matches);
-      }
-    });
-  };
+  const { pattern, mode, n } = config;
+  const options = { cwd: path.resolve(benchmarkDirectory, config.dir) };
 
   let noDead;
   bench.start();
 
-  for (let i = 0; i < config.n; i++) {
+  for (let i = 0; i < n; i++) {
     switch (mode) {
       case 'sync':
         noDead = globSync(pattern, options);
         break;
       case 'promise':
-        noDead = await globAsync(pattern, options);
+        noDead = await Array.fromAsync(globAsync(pattern, options));
         break;
       case 'callback':
-        noDead = await new Promise(callback);
+        noDead = await new Promise((resolve, reject) => {
+          glob(pattern, options, (err, matches) => {
+            if (err) {
+              reject(err);
+            } else {
+              resolve(matches);
+            }
+          });
+        });
         break;
       default:
         throw new Error(`Unknown mode: ${mode}`);
     }
   }
 
-  bench.end(config.n);
-  assert.ok(noDead);
+  bench.end(n);
+  assert.ok(noDead.length > 0);
 }

benchmark/path/matchesGlob-posix.js

@@ -10,8 +10,12 @@ const bench = common.createBenchmark(main, {
     'src/foo/bar/biz/baz/index.test.ts',
   ],
   pattern: [
+    'src/index.ts',
+    '**/*.ts',
+    '**/*.{ts,js}',
     'src/**/baz/*.test.ts',
     'src/**/baz/*.ts',
+    'src/**/index.@(test|spec).ts',
     'test/**/*.ts',
   ],
   n: [1e5],
@@ -24,5 +28,5 @@ function main({ path, pattern, n }) {
     a = posix.matchesGlob(path, pattern);
   }
   bench.end(n);
-  assert(a + 'a');
+  assert.strictEqual(typeof a, 'boolean');
 }

benchmark/path/matchesGlob-win32.js

@@ -11,8 +11,12 @@ const bench = common.createBenchmark(main, {
     'src\\foo\\bar\\biz\\baz\\index.test.ts',
   ],
   pattern: [
+    'src/index.ts',
+    '**/*.ts',
+    '**/*.{ts,js}',
     'src/**/baz/*.test.ts',
     'src/**/baz/*.ts',
+    'src/**/index.@(test|spec).ts',
     'test/**/*.ts',
   ],
   n: [1e5],
@@ -25,5 +29,5 @@ function main({ path, pattern, n }) {
     a = win32.matchesGlob(path, pattern);
   }
   bench.end(n);
-  assert(a + 'a');
+  assert.strictEqual(typeof a, 'boolean');
 }