[Feature Request]: Hide invoice groups (numbering systems)

[Federicod91]

Affected Area or Handler

invoices create

Problem Statement

I'd like to add the ability to hide invoice groups from previous years in the invoice creation window without deleting them.
Is there a way to do this, or perhaps implement this feature in the next version?

Proposed Solution

Add a button to hide the group on the invoice groups page.

Notes or context

No response

[nielsdrost7]

@coderabbitai make plan. Gamble on the Context, since that is missing, but just guess that the user is trying to hide invoices from before 2026.
It then probably needs a way to add that filter to the Invoices Index.

I need "Arrange, Act, Assert" scenarios

[nielsdrost7]

@coderabbitai how is it coming with that plan?

[coderabbitai[bot]]

Coding Plan

Summary

• Follow the established Mdl_clients active/inactive pattern exactly—TINYINT column, scope methods, checkbox with default-to-zero handling, and tabbed index view
• Create a new SQL migration file (044) to add invoice_group_active column with default value of 1 (preserving existing groups as active)
• Apply is_active() scope filter in all 7 Ajax methods that populate invoice group dropdowns
• No changes to invoice number generation or existing invoice records—hidden groups simply don't appear in new creation dialogs

Design Choices

Design Choice 1: Default value for existing invoice groups after migration

Options Considered:

1. Default existing groups to inactive (0), requiring manual activation
2. Default existing groups to active (1), preserving current behavior

Chosen Option: 2

Rationale: Defaulting to active ensures no disruption to existing workflows—all current groups continue working as before, and administrators can selectively hide old groups.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Phase 1: Database Schema and Model Layer

Add the invoice_group_active column to the database and extend the model with validation, default handling, and scope methods following the established Mdl_clients pattern.

Task 1: Create Database Migration

Add a new SQL migration file to add the active flag column to the invoice groups table.

• Create application/modules/setup/sql/044_1.8.0.sql (or appropriate version number)
• Add ALTER TABLE statement to add invoice_group_active TINYINT(1) NOT NULL DEFAULT 1 AFTER invoice_group_left_pad
• The default of 1 ensures all existing groups remain active after migration

Task 2: Extend Invoice Groups Model

Update the model to support the active flag with validation, database array handling, and scope methods.

• Update application/modules/invoice_groups/models/Mdl_invoice_groups.php
• Add invoice_group_active to validation_rules() array (field only, no required rule—checkbox semantics)
• Override db_array() method to default invoice_group_active to 0 when not present in POST (unchecked checkbox pattern from Mdl_clients)
• Add is_active() scope method that calls $this->filter_where('invoice_group_active', 1) and returns $this
• Add is_inactive() scope method that calls $this->filter_where('invoice_group_active', 0) and returns $this

🤖 Prompt for AI agents

Implement the database migration and model layer changes to support the new
`invoice_group_active` flag, following the established `Mdl_clients`
active/inactive pattern.

**Migration File:**
- Create `application/modules/setup/sql/044_1.8.0.sql`
- Add an `ALTER TABLE` statement to add the column `invoice_group_active
TINYINT(1) NOT NULL DEFAULT 1 AFTER invoice_group_left_pad`

**Model Updates**
(`application/modules/invoice_groups/models/Mdl_invoice_groups.php`):
- Add `invoice_group_active` to the `validation_rules()` array as a field entry
with no `required` rule (checkbox semantics)
- Override `db_array()` to explicitly default `invoice_group_active` to `0` when
the key is absent from POST data (unchecked checkbox pattern matching
`Mdl_clients`)
- Add `is_active()` scope method: calls
`$this->filter_where('invoice_group_active', 1)` and returns `$this`
- Add `is_inactive()` scope method: calls
`$this->filter_where('invoice_group_active', 0)` and returns `$this`

Phase 2: Admin Interface Updates

Update the invoice groups controller and views to support filtering by active status and toggling the flag via the edit form.

Task 1: Add Status Filtering to Controller

Extend the controller to support filtered views by active/inactive status.

• Update application/modules/invoice_groups/controllers/Invoice_groups.php
• Modify index() method to accept an optional $status parameter (default: 'active')
• Apply the appropriate scope method (is_active(), is_inactive(), or none for 'all') before pagination
• Pass the current $status value to the view for tab highlighting

Task 2: Update Index View with Status Tabs

Add navigation tabs and a status badge column to the invoice groups list view.

• Update application/modules/invoice_groups/views/index.php
• Add a three-button tab bar (Active / Inactive / All) above the table, following the pattern in clients/index.php
• Each tab links to invoice_groups/index/{status}/0 with appropriate btn-primary/btn-default classes based on current status
• Add an "Active" column to the table displaying a badge (<span class="label label-success"> for active, <span class="label label-danger"> for inactive)

Task 3: Add Active Checkbox to Form View

Add a checkbox to the invoice group edit form for toggling the active state.

• Update application/modules/invoice_groups/views/form.php
• Add a checkbox input for invoice_group_active with value 1
• Pre-check the checkbox when editing an existing active group using form_value('invoice_group_active')
• Position the checkbox appropriately within the form layout (consider placing in the panel header like clients, or as a standard form field)

🤖 Prompt for AI agents

Update the invoice groups controller and views to support active/inactive status
filtering and toggling, mirroring the pattern used in the clients module.

**Controller**
(`application/modules/invoice_groups/controllers/Invoice_groups.php`):
- Modify `index()` to accept an optional `$status` parameter defaulting to
`'active'`
- Before pagination, apply the matching scope: `is_active()` for `'active'`,
`is_inactive()` for `'inactive'`, and no scope for `'all'`
- Pass the current `$status` value to the view data for tab highlighting

**Index View** (`application/modules/invoice_groups/views/index.php`):
- Add a three-button tab bar (Active / Inactive / All) above the table following
the `clients/index.php` pattern
- Each tab links to `invoice_groups/index/{status}/0` and uses `btn-primary` for
the active tab and `btn-default` for others
- Add an "Active" column to the table with `<span class="label label-success">`
for active groups and `<span class="label label-danger">` for inactive groups

**Form View** (`application/modules/invoice_groups/views/form.php`):
- Add a checkbox input for `invoice_group_active` with value `1`
- Pre-check the checkbox when the group is active using
`form_value('invoice_group_active')`
- Position the checkbox appropriately within the form layout (panel header or
standard form field)

Phase 3: Filter Dropdowns to Active Groups Only

Update all Ajax controller methods that populate invoice group dropdowns to filter to active groups only, ensuring hidden groups don't appear in creation modals.

Task 1: Update Invoice Module Ajax Methods

Filter invoice group dropdowns in invoice-related creation modals.

• Update application/modules/invoices/controllers/Ajax.php
• In modal_create_invoice() (around line 460): change $this->mdl_invoice_groups->get() to $this->mdl_invoice_groups->is_active()->get()
• In modal_copy_invoice() (around line 307): apply the same is_active() filter
• In modal_create_credit() (around line 544): apply the same is_active() filter

Task 2: Update Quote Module Ajax Methods

Filter invoice group dropdowns in quote-related creation modals.

• Update application/modules/quotes/controllers/Ajax.php
• In modal_create_quote() (around line 402): change to $this->mdl_invoice_groups->is_active()->get()
• In modal_copy_quote() (around line 249): apply the same is_active() filter
• In modal_quote_to_invoice() (around line 441): apply the same is_active() filter

Task 3: Update Settings Module

Filter invoice group dropdowns in the settings page for default group selection.

• Update application/modules/settings/controllers/Settings.php
• In the main settings method (around line 187): change the invoice groups query to use is_active() filter
• This affects the default invoice group and default quote group dropdowns in settings

🤖 Prompt for AI agents

Apply the `is_active()` scope filter to all 7 Ajax/controller methods that
populate invoice group dropdowns, so that inactive groups are hidden from all
creation modals and settings dropdowns.

**Invoices Ajax** (`application/modules/invoices/controllers/Ajax.php`):
- `modal_create_invoice()` (~line 460): change
`$this->mdl_invoice_groups->get()` →
`$this->mdl_invoice_groups->is_active()->get()`
- `modal_copy_invoice()` (~line 307): apply the same `is_active()` filter
- `modal_create_credit()` (~line 544): apply the same `is_active()` filter

**Quotes Ajax** (`application/modules/quotes/controllers/Ajax.php`):
- `modal_create_quote()` (~line 402): apply `is_active()` filter
- `modal_copy_quote()` (~line 249): apply `is_active()` filter
- `modal_quote_to_invoice()` (~line 441): apply `is_active()` filter

**Settings Controller**
(`application/modules/settings/controllers/Settings.php`):
- Main settings method (~line 187): apply `is_active()` filter to the invoice
groups query, affecting both the default invoice group and default quote group
dropdowns

Research

This is a CodeIgniter 3 application with a modular MVC structure under application/modules/. The invoice groups module (application/modules/invoice_groups/) contains a model extending Response_Model, a controller extending Admin_Controller, and index/form views. The codebase has an established active/inactive toggle pattern in Mdl_clients using a TINYINT column, scope methods (is_active(), is_inactive()), and a status() controller action with tabbed navigation. Database migrations use a custom numbered SQL file system in application/modules/setup/sql/, with the next available file being 044_*.sql. Invoice groups are loaded into dropdowns in 7 different Ajax controller methods across the invoices, quotes, and settings modules.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Task: 1

Implement the database migration and model layer changes to support the new
`invoice_group_active` flag, following the established `Mdl_clients`
active/inactive pattern.

**Migration File:**
- Create `application/modules/setup/sql/044_1.8.0.sql`
- Add an `ALTER TABLE` statement to add the column `invoice_group_active
TINYINT(1) NOT NULL DEFAULT 1 AFTER invoice_group_left_pad`

**Model Updates**
(`application/modules/invoice_groups/models/Mdl_invoice_groups.php`):
- Add `invoice_group_active` to the `validation_rules()` array as a field entry
with no `required` rule (checkbox semantics)
- Override `db_array()` to explicitly default `invoice_group_active` to `0` when
the key is absent from POST data (unchecked checkbox pattern matching
`Mdl_clients`)
- Add `is_active()` scope method: calls
`$this->filter_where('invoice_group_active', 1)` and returns `$this`
- Add `is_inactive()` scope method: calls
`$this->filter_where('invoice_group_active', 0)` and returns `$this`
===============================================================================

Task: 2

Update the invoice groups controller and views to support active/inactive status
filtering and toggling, mirroring the pattern used in the clients module.

**Controller**
(`application/modules/invoice_groups/controllers/Invoice_groups.php`):
- Modify `index()` to accept an optional `$status` parameter defaulting to
`'active'`
- Before pagination, apply the matching scope: `is_active()` for `'active'`,
`is_inactive()` for `'inactive'`, and no scope for `'all'`
- Pass the current `$status` value to the view data for tab highlighting

**Index View** (`application/modules/invoice_groups/views/index.php`):
- Add a three-button tab bar (Active / Inactive / All) above the table following
the `clients/index.php` pattern
- Each tab links to `invoice_groups/index/{status}/0` and uses `btn-primary` for
the active tab and `btn-default` for others
- Add an "Active" column to the table with `<span class="label label-success">`
for active groups and `<span class="label label-danger">` for inactive groups

**Form View** (`application/modules/invoice_groups/views/form.php`):
- Add a checkbox input for `invoice_group_active` with value `1`
- Pre-check the checkbox when the group is active using
`form_value('invoice_group_active')`
- Position the checkbox appropriately within the form layout (panel header or
standard form field)
===============================================================================

Task: 3

Apply the `is_active()` scope filter to all 7 Ajax/controller methods that
populate invoice group dropdowns, so that inactive groups are hidden from all
creation modals and settings dropdowns.

**Invoices Ajax** (`application/modules/invoices/controllers/Ajax.php`):
- `modal_create_invoice()` (~line 460): change
`$this->mdl_invoice_groups->get()` →
`$this->mdl_invoice_groups->is_active()->get()`
- `modal_copy_invoice()` (~line 307): apply the same `is_active()` filter
- `modal_create_credit()` (~line 544): apply the same `is_active()` filter

**Quotes Ajax** (`application/modules/quotes/controllers/Ajax.php`):
- `modal_create_quote()` (~line 402): apply `is_active()` filter
- `modal_copy_quote()` (~line 249): apply `is_active()` filter
- `modal_quote_to_invoice()` (~line 441): apply `is_active()` filter

**Settings Controller**
(`application/modules/settings/controllers/Settings.php`):
- Main settings method (~line 187): apply `is_active()` filter to the invoice
groups query, affecting both the default invoice group and default quote group
dropdowns

💡 Iterate on the plan with: `@coderabbitai` <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!

[nielsdrost7]

@Federicod91 I've also converted your old issue to a discussion, so maybe those 2 can be merged and maybe you can clarify what groups you want to hide.

[Federicod91]

I have the following invoice groups:
Invoices 2026
Invoices 2025
Invoices 2024
Invoices 2023, etc.

I want to display only the Invoices 2026 group on the invoice creation page and hide all the others.

[nielsdrost7]

See https://github.com/orgs/InvoicePlane/discussions/1584
In case to prevent duplication