The P384 variant in the Attestation type https://github.com/oxidecomputer/dice-util/blob/d4c761370597e7476782c1225b70505142ead378/helios-rot/src/lib.rs#L60 assumes that the Sha2_384 digest is being used. This is the default for the p384 crate, and the recommendation from NIST. But use of Sha3_384 is allowed, as is the 512 variants. Use digest algorithms with smaller output is possible but discouraged. We need to add an identifier for the hash digest to the variants in this enum.
The
P384variant in theAttestationtype https://github.com/oxidecomputer/dice-util/blob/d4c761370597e7476782c1225b70505142ead378/helios-rot/src/lib.rs#L60 assumes that theSha2_384digest is being used. This is the default for thep384crate, and the recommendation from NIST. But use ofSha3_384is allowed, as is the 512 variants. Use digest algorithms with smaller output is possible but discouraged. We need to add an identifier for the hash digest to the variants in this enum.