Skip to content

Use of bail_unless! is highly problematic #11051

Description

@andrewjstone

Throughout trust quorum, and likely in other cases, we return errors when invariants aren't met. The easiest way to do this inside a transaction is to call the bail_unless! macro. Unfortunately this always returns a 500 error that is then likely to be presented to the API. It would be better to not use this, or to build a similar macro that can return better error codes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions