Component
Other
Priority
P2
Summary
The test suite hardcodes the TLD as the literal .dot in roughly 36 places, for example string.concat(label, ".dot"). The TLD is per network and read live from the protocol registry, and the fixture already exposes it through protocolRegistry.tld(), derived from the single TLD_LABEL constant in BaseDotns. The literals drift from the configured TLD, so a change to TLD_LABEL would not flow through these assertions.
Proposal
- Replace
string.concat(label, ".dot") and similar literals with string.concat(label, protocolRegistry.tld()).
- Keep
TLD_LABEL as the single value the fixture initialises the registry with, so every derivation follows from one place.
Acceptance criteria
Component
Other
Priority
P2
Summary
The test suite hardcodes the TLD as the literal
.dotin roughly 36 places, for examplestring.concat(label, ".dot"). The TLD is per network and read live from the protocol registry, and the fixture already exposes it throughprotocolRegistry.tld(), derived from the singleTLD_LABELconstant inBaseDotns. The literals drift from the configured TLD, so a change toTLD_LABELwould not flow through these assertions.Proposal
string.concat(label, ".dot")and similar literals withstring.concat(label, protocolRegistry.tld()).TLD_LABELas the single value the fixture initialises the registry with, so every derivation follows from one place.Acceptance criteria
protocolRegistry.tld().TLD_LABELflows through every affected assertion with no other edits.