Test utils feature unification#1599
Merged
benalleng merged 1 commit intoJun 4, 2026
Merged
Conversation
benalleng
force-pushed
the
test-utils-feature-unification
branch
2 times, most recently
from
7b575f3 to
53314dc
Compare
benalleng
force-pushed
the
test-utils-feature-unification
branch
from
53314dc to
16b314a
Compare
Collaborator
Coverage Report for CI Build 26896944251Coverage remained the same at 85.358%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
bc1cindy
reviewed
Jun 4, 2026
Collaborator
Author
Yep, 76f2153 adds fetaure specific tests directly to |
xstoicunicornx
approved these changes
Jun 4, 2026
xstoicunicornx
left a comment
xstoicunicornx
left a comment
Collaborator
There was a problem hiding this comment.
utACK 16b314a
These tests are so organized now nice work!
Reviewed and tested with the various feature flag combos. v1 only runs v1 tests, v2 only runs v2 tests, and only when both flags are active are v1/v2 combined integration tests run. LGTM.
Contributor
|
This breaks publication. Trilemma explained in #1613 |
2 tasks
DanGould
added a commit
that referenced
this pull request
Jun 8, 2026
The public `v2` feature referenced `payjoin-test-utils/v2`, but payjoin-test-utils is a dev-dependency that itself depends on payjoin. Referencing a dev-dependency feature from a published feature makes the manifest unpublishable: cargo resolves the dev-dependency against crates.io, where no test-utils version exposes `v2`, and none could, since test-utils depends on this still-unpublished payjoin version. Drop the test-utils edge from the `v2` feature and declare the dev-dependency path-only with `v2` enabled directly. Cargo omits path-only dev-dependencies from the published manifest, so payjoin packages cleanly. The test-utils helpers are only used under cfg(test), so the shipped library is unchanged. This reintroduces v2 into `--features v1` test builds through feature unification (lib test count rises from 125 to 217), undoing the isolation added in #1599. Restoring that isolation requires splitting payjoin-test-utils and is tracked as a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1598
This allows the payjoin crate to only test the
v1feature gated tests on their own without also pulling inv2as payjoin-test-utils now no longer automatically pulls in thev2feature.Claude caught the
directory.rsissue which was occuring because of thev2only re-export ofShortId.Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.