From 9267c3b3621fd0b6b872b83732792f58bca7827b Mon Sep 17 00:00:00 2001
From: Mark Scherer <dereuromark@users.noreply.github.com>
Date: Sat, 18 Jul 2026 17:32:30 +0200
Subject: [PATCH] Keep tight list items unwrapped when source lines are enabled

The tight-list renderer strips a plain paragraph wrapper from item
content, but a paragraph stamped with data-source-line no longer matched
the pattern, so enabling sourceLines grew <p> wrappers inside tight
items - a structure change the opt-in attribute-only option must never
cause. Strip anchor-only wrappers the same way (the li keeps its own
anchor, matching carve-js and carve-rs) and lock the contract with a
byte-identity regression test.
---
 src/Renderer/HtmlRenderer.php             |  4 +++-
 tests/TestCase/SourceLineTrackingTest.php | 23 ++++++++++++++++++-----
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/src/Renderer/HtmlRenderer.php b/src/Renderer/HtmlRenderer.php
index 3eea16d..7df6ba6 100644
--- a/src/Renderer/HtmlRenderer.php
+++ b/src/Renderer/HtmlRenderer.php
@@ -768,7 +768,9 @@ protected function renderListItem(ListItem $node, bool $tight = true): string
             // This handles both:
             // 1. Single paragraph: <p>text</p> -> text
             // 2. Paragraph followed by nested list: <p>text</p>\n<ul>... -> text\n<ul>...
-            $content = preg_replace('/^<p>(.+?)<\/p>(\n)?/s', '$1$2', $content) ?? $content;
+            // A data-source-line-only wrapper is stripped too (the source-line
+            // option must never change structure; the <li> keeps the anchor).
+            $content = preg_replace('/^<p(?: data-source-line="\d+")?>(.+?)<\/p>(\n)?/s', '$1$2', $content) ?? $content;
         }
 
         // Handle task list items
diff --git a/tests/TestCase/SourceLineTrackingTest.php b/tests/TestCase/SourceLineTrackingTest.php
index 74b3704..dc7be52 100644
--- a/tests/TestCase/SourceLineTrackingTest.php
+++ b/tests/TestCase/SourceLineTrackingTest.php
@@ -88,7 +88,9 @@ public function testListSyntheticSeparatorDoesNotBecomeSourceLine(): void
         $converter = new DjotConverter(sourceLines: true);
         $html = $converter->convert("- first\n  {.note}\n  second\n");
 
-        $this->assertStringContainsString('<p data-source-line="1">first</p>', $html);
+        // The tight item's lead stays unwrapped (anchor-only <p> wrappers are
+        // stripped like plain ones); the li carries the anchor.
+        $this->assertMatchesRegularExpression('/<li data-source-line="1">\nfirst\n/', $html);
         $this->assertStringContainsString('<p class="note" data-source-line="3">second</p>', $html);
         $this->assertStringNotContainsString('data-source-line="0"', $html);
     }
@@ -99,11 +101,9 @@ public function testListInsideBlockquoteComposesLineMap(): void
         $html = $converter->convert("> - quoted item\n>   - nested item\n");
 
         $this->assertMatchesRegularExpression('/<ul data-source-line="1">/', $html);
-        $this->assertMatchesRegularExpression('/<li data-source-line="1">/', $html);
-        $this->assertStringContainsString('<p data-source-line="1">quoted item</p>', $html);
+        $this->assertMatchesRegularExpression('/<li data-source-line="1">\nquoted item\n/', $html);
         $this->assertMatchesRegularExpression('/<ul data-source-line="2">/', $html);
-        $this->assertMatchesRegularExpression('/<li data-source-line="2">/', $html);
-        $this->assertStringContainsString('<p data-source-line="2">nested item</p>', $html);
+        $this->assertMatchesRegularExpression('/<li data-source-line="2">\nnested item\n/', $html);
     }
 
     public function testFootnoteContentBlocksAreStamped(): void
@@ -189,4 +189,17 @@ public function testCustomBlockContentIsNotStampedWithLocalLines(): void
         $this->assertStringContainsString('<div data-source-line="3">', $html);
         $this->assertStringContainsString('<p>nested</p>', $html);
     }
+
+    public function testEnabledOutputIsStructureIdenticalToDisabled(): void
+    {
+        // The option is attribute-only: stripping the stamped attributes must
+        // reproduce the default output byte for byte. Regression: tight list
+        // items used to grow <p> wrappers because the stamped paragraph no
+        // longer matched the renderer's tight-strip pattern.
+        $doc = "> - quoted item\n\n- a\n- b\n\n1. loose\n\n  para\n\n:: nope\n";
+        $off = (new DjotConverter())->convert($doc);
+        $on = (new DjotConverter(sourceLines: true))->convert($doc);
+
+        $this->assertSame($off, preg_replace('/ data-source-line="\d+"/', '', $on));
+    }
 }