ext/soap: fix leak when load_wsdl_ex() fails to load

Author: DanielEScherzer

ext/soap/php_sdl.c

@@ -364,7 +364,12 @@ static void load_wsdl_ex(zval *this_ptr, char *struri, sdlCtx *ctx, int include)
 			xmlAttrPtr tmp = get_attribute(trav->properties, "location");
 			if (tmp) {
 				xmlChar *uri = schema_location_construct_uri(tmp);
-				load_wsdl_ex(this_ptr, (char*)uri, ctx, 1);
+				zend_try {
+					load_wsdl_ex(this_ptr, (char*)uri, ctx, 1);
+				} zend_catch {
+					xmlFree(uri);
+					zend_bailout();
+				} zend_end_try();
 				xmlFree(uri);
 			}
 

ext/soap/tests/load_wsdl_ex-failure-leak.phpt

@@ -0,0 +1,61 @@
+--TEST--
+Memory leak when load_wsdl_ex() fails
+--EXTENSIONS--
+soap
+--INI--
+soap.wsdl_cache_enabled=0
+--SKIPIF--
+<?php
+if (!file_exists(__DIR__ . "/../../../sapi/cli/tests/php_cli_server.inc")) {
+	echo "skip sapi/cli/tests/php_cli_server.inc required but not found";
+}
+?>
+--FILE--
+<?php
+
+include __DIR__ . "/../../../sapi/cli/tests/php_cli_server.inc";
+
+$context = stream_context_create([
+	'http' => ['header' => [
+		"Authorization: Bar",
+		"aUTHORIZATION: Baz",
+	]],
+]);
+
+$wsdl = <<<END
+<?xml version="1.0" encoding="utf-8"?>
+<definitions
+  xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/"
+  xmlns="http://schemas.xmlsoap.org/wsdl/"
+>
+  <import location="http://localhost:0/index.php"/>
+</definitions>
+END;
+
+$server_code = "echo <<<END\n$wsdl\nEND;";
+php_cli_server_start($server_code);
+$wsdl_server_port = PHP_CLI_SERVER_PORT;
+
+try {
+	$client = new SoapClient("http://localhost:$wsdl_server_port", [
+		'soap_version' => SOAP_1_1,
+		'stream_context' => $context,
+	]);
+} catch (SoapFault $e) {
+	echo get_class($e) . ': ' . $e->getMessage() . "\n";
+	echo "--- Raw Server Response Body ---\n";
+	var_dump(@file_get_contents("http://localhost:$wsdl_server_port", false, $context));
+}
+
+?>
+--EXPECT--
+SoapFault: SOAP-ERROR: Parsing WSDL: Couldn't load from 'http://localhost:0/index.php' : failed to load external entity "http://localhost:0/index.php"
+
+--- Raw Server Response Body ---
+string(216) "<?xml version="1.0" encoding="utf-8"?>
+<definitions
+  xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/"
+  xmlns="http://schemas.xmlsoap.org/wsdl/"
+>
+  <import location="http://localhost:0/index.php"/>
+</definitions>"