Skip to content

Commit 7aa003e

Browse files
committed
Merge branch 'PHP-8.5' into PHP-8.6
* PHP-8.5: Fix alternate form flag for %x testing stale signed value
2 parents 367c38d + 50b257f commit 7aa003e

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
--TEST--
2+
Unknown CDF property IDs are printed with the 0x prefix
3+
--EXTENSIONS--
4+
fileinfo
5+
--FILE--
6+
<?php
7+
$data = file_get_contents(__DIR__ . '/resources/test.ppt');
8+
$data[40576] = "\x1f";
9+
$desc = (new finfo())->buffer($data);
10+
echo substr($desc, strrpos($desc, ', ') + 2), "\n";
11+
?>
12+
--EXPECT--
13+
0x1f: 0

‎main/snprintf.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ static size_t format_converter(buffy * odp, const char *fmt, va_list ap) /* {{{
798798
}
799799
s = ap_php_conv_p2(ui_num, 4, *fmt, &num_buf[NUM_BUF_SIZE], &s_len);
800800
FIX_PRECISION(adjust_precision, precision, s, s_len);
801-
if (alternate_form && i_num != 0) {
801+
if (alternate_form && ui_num != 0) {
802802
*--s = *fmt; /* 'x' or 'X' */
803803
*--s = '0';
804804
s_len += 2;

0 commit comments

Comments
 (0)