[RFC] Deprecate ReflectionMethod invocation for static methods with objects

`ReflectionMethod::invoke()` and `::invokeArgs()` are affected, but share
implementation code and so are updated together.

https://wiki.php.net/rfc/deprecations_php_8_6

Author: DanielEScherzer

UPGRADING

@@ -483,6 +483,9 @@ PHP 8.6 UPGRADE NOTES
   . Calling ReflectionProperty::setRawValue() with an object that is not an
     instance of the class on which the property was declared is now deprecated.
     RFC: https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_reflectionpropertysetvalue_and_reflectionpropertysetrawvalue_with_wrong_types
+  . Calling ReflectionMethod::invoke() or ReflectionMethod::invokeArgs() with
+    an object and a static method is now deprecated.
+    RFC: https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_reflectionmethodinvoke_and_reflectionmethodinvokeargs_with_objects_for_static_methods
 
 - SPL:
   . The spl_classes() function is now deprecated, use

ext/reflection/php_reflection.c

@@ -3375,7 +3375,21 @@ static void reflection_method_invoke(INTERNAL_FUNCTION_PARAMETERS, bool variadic
 	 * Else, we verify that the given object is an instance of the class.
 	 */
 	if (mptr->common.fn_flags & ZEND_ACC_STATIC) {
-		object = NULL;
+		if (object) {
+			zend_string *method_name = get_active_function_or_method_name();
+			zend_error(
+				E_DEPRECATED,
+				"Calling %pS() for static method %pS::%pS() does not need an object parameter",
+				method_name,
+				mptr->common.scope->name,
+				mptr->common.function_name
+			);
+			zend_string_release(method_name);
+			if (UNEXPECTED(EG(exception))) {
+				RETURN_THROWS();
+			}
+			object = NULL;
+		} 
 		obj_ce = mptr->common.scope;
 	} else {
 		if (!object) {

ext/reflection/tests/ReflectionMethod_invokeArgs_error3.phpt

@@ -65,7 +65,7 @@ try {
 }
 
 ?>
---EXPECT--
+--EXPECTF--
 Non-instance:
 string(72) "Given object is not an instance of the class this method was declared in"
 
@@ -75,6 +75,8 @@ Exception: Using $this when not in object context
 NULL
 
 Private method:
+
+Deprecated: Calling ReflectionMethod::invokeArgs() for static method TestClass::privateMethod() does not need an object parameter in %s on line %d
 Called privateMethod()
 NULL
 

ext/reflection/tests/ReflectionMethod_invoke_basic.phpt

@@ -104,6 +104,8 @@ NULL
 Static method:
 ReflectionMethod::invoke() expects at least 1 argument, 0 given
 ReflectionMethod::invoke(): Argument #1 ($object) must be of type ?object, true given
+
+Deprecated: Calling ReflectionMethod::invoke() for static method TestClass::staticMethod() does not need an object parameter in %s on line %d
 Called staticMethod()
 Exception: Using $this when not in object context
 NULL

ext/reflection/tests/ReflectionMethod_invoke_error1.phpt

@@ -53,14 +53,16 @@ try {
 }
 
 ?>
---EXPECT--
+--EXPECTF--
 invoke() on a non-object:
 string(85) "ReflectionMethod::invoke(): Argument #1 ($object) must be of type ?object, true given"
 
 invoke() on a non-instance:
 string(72) "Given object is not an instance of the class this method was declared in"
 
 Private method:
+
+Deprecated: Calling ReflectionMethod::invoke() for static method TestClass::privateMethod() does not need an object parameter in %s on line %d
 Called privateMethod()
 NULL