Repository navigation
ext/openssl: fix use after free when callbacks close streams - #24065
DanielEScherzer wants to merge 5 commits into
Conversation
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
It looks good, just one place might be missing.
| const unsigned char *session_id = SSL_SESSION_get_id(session, &session_id_len); | ||
|
|
||
| zval args[2]; | ||
|
|
There was a problem hiding this comment.
shouldn't it be added here (php_openssl_session_remove_cb) as well?
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
It looks good, just one place might be missing.
|
I wonder if we should also check for exception in php_openssl_handshake_early_data . Not exactly related but just something that I noticed when checking this. |
|
I wasn't able to trigger an error with session_remove_cb closing the stream, maybe because at that point it is not going to be used again? For exceptions in the early data callback, I also didn't get any issues, tested with |
2 participants
See individual commits for details