Repository navigation
Conversation
This is a security bug, since it makes PBKDF2 faster for attackers than defenders. So it should be fixed from PHP 8.2 on. Fixes php#9604
Sjord
force-pushed
the
pbkdf2-perf-bug-82
branch
from
October 8, 2026 07:56
0e39d92 to
690e0ac
Compare
Sjord
marked this pull request as draft
October 8, 2026 09:31
LamentXU123
reviewed
Oct 8, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Have you benchmarked the difference between it? Generally we treat performance improvements as a feature to be landed on master only and only vulnerbility fixes qualifies for 8.2. @php/release-managers-82 ?
| due to partial address comparison). (CVE-2026-91768) (Alexandre Daubois) | ||
|
|
||
| - Hash: | ||
| . Improved performance of hash_pbkdf2. (Sjoerd Langkemper) |
Member
There was a problem hiding this comment.
Feel free to add a UPGRADING entry.
Contributor
Author
|
|
Sjord
marked this pull request as ready for review
October 8, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a security bug, since it makes PBKDF2 faster for attackers than defenders. So it should be fixed from PHP 8.2 on.