Repository navigation
Conversation
fcgi_close() half-closed the connection with shutdown(fd, 1), meaning SHUT_WR. Every platform PHP supports uses 1 for it, but POSIX does not fix the value, and WASI uses 2. There the reading side was shut instead. The drain loop then ended at once, and close() could reset the connection with the web server's last FCGI_STDIN unread, which lost the response.
ndossche
approved these changes
Oct 9, 2026
ndossche
left a comment
Member
There was a problem hiding this comment.
You're correct, and SHUT_WR==1 on Linux, thanks
LamentXU123
approved these changes
Oct 10, 2026
Member
|
Thank you! |
bukka
pushed a commit
to bukka/php-src
that referenced
this pull request
Oct 10, 2026
* PHP-8.4: Fix phpGH-24229: Use SHUT_WR when closing FastCGI connections (php#24230)
bukka
pushed a commit
to bukka/php-src
that referenced
this pull request
Oct 10, 2026
* PHP-8.5: Fix phpGH-24229: Use SHUT_WR when closing FastCGI connections (php#24230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-24229.
The quoted description below, and the checks it describes, were done with an LLM (Claude). I reviewed them.