Repository navigation
Mobile (Android): thread filter menu should follow the theme and show project logos #27985
Umais-Adeed
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Where: mobile app (Android), the thread filter menu on the home screen and the tablet sidebar.
Problem
The Android filter menu doesn't look like the rest of the app:
Proposal
I'd like approval for two small PRs:
PR 1: Android menus use the theme's card color and rounded corners. Every Android menu switches from the raised-surface color to the grouped-card color and uses a 16dp radius, scaled with text size like the other menu sizes. 3 files, +11/−4. Material You already maps both colors to its own surface containers.
Branch:
fix/mobile-android-menu-surfacePR 2: The Android thread filter shows project logos and row icons. Android menu rows can take an optional custom leading icon. The phone and tablet filters use it to show each project's existing
ProjectFavicon(its real favicon, or its colored initials), and give the Environment/Project rows matching symbols so the column lines up. Other menus are unchanged. 9 files, +106/−22.Branch:
feat/mobile-filter-menu-iconsThe two PRs are independent and can land separately.
Screenshots (Android 17 emulator, demo data)
PR 1: theme color and corners
PR 2: logos and icons
Both together
Captured with the repo's showcase demo environments (Moonbase Terminal and Kernel Cabin), so the T3 Code, React, and Linux projects show their real favicons. Projects without a favicon fall back to their colored initials, the same as in the thread list.
Checked and not checked
vp run check:changedpasses format, lint, knip, tests, and the React compiler. The affected packages pass typecheck individually.Does this direction and scope work for you? If so, I'll open both PRs and link this discussion.
All reactions