Unique constrains drop for 'SyncEngine.migratePrimaryKeys'

[diatoming]

Hi,
i've tried to drop unique constraints at the same time inside SyncEngine.migratePrimaryKeys func.
By using the parser tool, i managed to drop the constraints.
The problem is that there might be missing some whitespace or '\n' characters in the new schema after unique constraints dropped.

Example1
before:

CREATE TABLE "users" (
"id" INTEGER,
"title" TEXT NOT NULL,

PRIMARY KEY("id"),
UNIQUE("title") ON CONFLICT REPLACE
) STRICT

after:

CREATE TABLE "new_users" (
"id" TEXT PRIMARY KEY NOT NULL ON CONFLICT REPLACE DEFAULT ("uuid"()),
"title" TEXT NOT NULL

) STRICT

Example2
before:

CREATE TABLE "tags" (
"title" TEXT NOT NULL UNIQUE,
"user" TEXT NOT NULL,
"name" TEXT NOT NULL UNIQUE ON CONFLICT IGNORE
) STRICT

after:

CREATE TABLE "new_tags" (
  "id" TEXT PRIMARY KEY NOT NULL ON CONFLICT REPLACE DEFAULT ("uuid"()),
  "title" TEXT NOT NULL ,
  "user" TEXT NOT NULL,
  "name" TEXT NOT NULL) STRICT

Is that a problem? Or will it be accepted?

[mbrandonw]

Hi @diatoming, that doesn't seem like the worst thing, but please do open a PR and we can see if we can help out. Also be sure to add tests that show these problems.

[diatoming]

Hi @mbrandonw, i'm not sure whether the tests is enough or not, but i added a test which comparing the new schema generated with the original schema.