New(ish) git `manager` handles GitHub specially

[gaborcsardi]

In particular, there is now a git credential-manager github command, with subcommands. Also, if there are multiple GitHub credentials in the credential store, then manager wants to start a prompt, and if we forbid that it'll just fail, which is not good.

AFAIR manager is not the default credential helper many more, but I should double check this behavior in manager-core as well.

[jennybc]

I am trying to use gitcreds on Windows and it just seems generally broken. As in, I can't even do gitcreds::gitcreds_set() and then gitcreds_get() in the same session with any success.

> gitcreds::gitcreds_set()


? Enter password or token: ghp_xxxxxxxxx
-> Adding new credentials...
-> Removing credentials from cache...
-> Done.
> gitcreds::gitcreds_get()
Error in throw(new_error("gitcreds_no_credentials", url = url)) : 
  Could not find any credentials

[jennybc]

I feel like this is part of the problem. Why does gitcreds think I have 2 active credential managers? And I think it will default to the first, "manager", which AFAICT is the older one.

> gitcreds::gitcreds_list_helpers()
[1] "manager"      "manager-core"

In my user-level git config, I only have "manager-core" configured:

[user]
	name = Jenny Bryan
	email = jenny.f.bryan@gmail.com
[init]
	defaultBranch = main
[pull]
	rebase = true
[core]
	excludesFile = C:/Users/jenny/.gitignore
[credential]
	helper = manager-core

[jennybc]

I nuked the "manager" helper, which was apparently set at the system level. So gitcreds only sees "manager-core" now (and I installed oskeyring). And yet I still can't set/get creds:

> gitcreds::gitcreds_set()


? Enter password or token: ghp_xxxxxxxxxx
-> Adding new credentials...
-> Removing credentials from cache...
-> Done.
> gitcreds::gitcreds_get()
Error in throw(new_error("gitcreds_no_credentials", url = url)) : 
  Could not find any credentials
> gitcreds::gitcreds_list_helpers()
[1] "manager-core"

[jennybc]

I can list creds, but cannot get any:

> gitcreds_list()
[[1]]
<oskeyring_windows_item: generic>
 target_name: git:https://github.com
 persist: local_machine
 username: jennybc
 credential_blob: <-- hidden -->

[[2]]
<oskeyring_windows_item: generic>
 target_name: git:https://PersonalAccessToken@github.com
 persist: local_machine
 username: PersonalAccessToken
 credential_blob: <-- hidden -->

[[3]]
<oskeyring_windows_item: generic>
 target_name: git:https://jennybc@github.com
 persist: local_machine
 username: jennybc
 credential_blob: <-- hidden -->

> gitcreds_get()
Error in throw(new_error("gitcreds_no_credentials", url = url)) : 
  Could not find any credentials

[jennybc]

If I set the appropriate environment variable, I still can't get credentials. So I basically can't use gitcreds at all on this Windows machine at this time.

> library(gitcreds)
> Sys.getenv(gitcreds_cache_envvar("https://github.com"))
[1] "ghp_xxxxxxxxxx"
> gitcreds_get()
<gitcreds>
  protocol: NA
  host    : NA
  username: NA
  password: <-- hidden -->