Updated ReactiveUI/Splat with Trimming

[mysteryx93]

I'm updating some older code and am a little bit confused by the changes.

First, Avalonia.ReactiveUI got replaced by ReactiveUI.Avalonia, so far so good.

Now, ReactiveUI wants to do the registrations when calling UseReactiveUI(); and Splat saw a lot of changes.

I was using Splat SourceGenerator for performance and to not have any issue with trimming of self-contained EXE.

If I just use ReactiveUI.Avalonia's default registration syntax, does it have the same performance improvements or better? Will it work with Trimming correctly?

It's a simple demo project I'm trying to update first

Program.cs

using System;
using Avalonia;
using ReactiveUI.Avalonia;

namespace Demo.Avalonia.ActivateNonModalDialog;

public class Program
{
    // Initialization code. Don't use any Avalonia, third-party APIs or any
    // SynchronizationContext-reliant code before AppMain is called: things aren't initialized
    // yet and stuff might break.
    [STAThread]
    public static void Main(string[] args) => BuildAvaloniaApp()
        .StartWithClassicDesktopLifetime(args);

    // Avalonia configuration, don't remove; also used by visual designer.
    public static AppBuilder BuildAvaloniaApp()
        => AppBuilder.Configure<App>()
            .UsePlatformDetect()
            .LogToTrace()
            .UseReactiveUI(rxui => {  });
}

App.axaml.cs

using System;
using Avalonia;
using Avalonia.Markup.Xaml;
using HanumanInstitute.MvvmDialogs;
using HanumanInstitute.MvvmDialogs.Avalonia;
using Microsoft.Extensions.Logging;
using Splat;

namespace Demo.Avalonia.ActivateNonModalDialog;

public class App : Application
{
    public override void Initialize()
    {
        AvaloniaXamlLoader.Load(this);

        var build = Locator.CurrentMutable;
        var loggerFactory = LoggerFactory.Create(builder => builder.AddFilter(logLevel => true).AddDebug());

        build.RegisterLazySingleton(() => (IDialogService)new DialogService(
            new DialogManager(
                viewLocator: new ViewLocator(),
                logger: loggerFactory.CreateLogger<DialogManager>()),
            viewModelFactory: x => Locator.Current.GetService(x)));

        SplatRegistrations.Register<MainWindowViewModel>();
        SplatRegistrations.Register<CurrentTimeDialogViewModel>();
        SplatRegistrations.SetupIOC();
    }

    public override void OnFrameworkInitializationCompleted()
    {
        GC.KeepAlive(typeof(DialogService));
        DialogService.Show(null, MainWindow);

        base.OnFrameworkInitializationCompleted();
    }

    public static MainWindowViewModel MainWindow => Locator.Current.GetService<MainWindowViewModel>()!;
    public static CurrentTimeDialogViewModel CurrentTimeDialog => Locator.Current.GetService<CurrentTimeDialogViewModel>()!;
    public static IDialogService DialogService => Locator.Current.GetService<IDialogService>()!;
}

[mysteryx93]

There are indeed considerable changes, documented here
https://www.reactiveui.net/docs/upgrading/rxappbuilder-migration