[CodeQuality] Skip assertNull/assertEmpty in AssertEmptyNullableObjectToAssertInstanceofRector (#780)

Author: TomasVotruba

rules-tests/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector/Fixture/assert_make_empty.php.inc

@@ -11,7 +11,7 @@ final class KeepCustomMessage extends TestCase
     {
         $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
 
-        $this->assertNull($someObject, 'some message');
+        $this->assertNotNull($someObject, 'some message');
     }
 }
 
@@ -30,7 +30,7 @@ final class KeepCustomMessage extends TestCase
     {
         $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
 
-        $this->assertNotInstanceOf(\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject::class, $someObject, 'some message');
+        $this->assertInstanceOf(\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject::class, $someObject, 'some message');
     }
 }
 

rules-tests/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector/Fixture/include_assert_null.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Fixture;
+
+use Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipAssertEmpty extends TestCase
+{
+    public function test()
+    {
+        if (mt_rand(0, 1)) {
+            $someObject = null;
+        } else {
+            $someObject = new SomeTypeObject();
+        }
+
+        $this->assertEmpty($someObject);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector/Fixture/keep_custom_message.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Fixture;
+
+use CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector\Source\SomeTypeObject;
+use PHPUnit\Framework\TestCase;
+
+final class SkipAssertNull extends TestCase
+{
+    public function test()
+    {
+        $someObject = mt_rand(0, 1) ? new SomeTypeObject() : null;
+
+        $this->assertNull($someObject);
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/MethodCall/AssertEmptyNullableObjectToAssertInstanceofRector/Fixture/skip_assert_empty.php.inc

@@ -84,7 +84,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (! $this->isNames($node->name, ['assertNotEmpty', 'assertEmpty', 'assertNull', 'assertNotNull'])) {
+        if (! $this->isNames($node->name, ['assertNotEmpty', 'assertNotNull'])) {
             return null;
         }
 
@@ -107,12 +107,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $methodName = $this->isNames(
-            $node->name,
-            ['assertEmpty', 'assertNull']
-        ) ? 'assertNotInstanceOf' : 'assertInstanceOf';
-
-        $node->name = new Identifier($methodName);
+        $node->name = new Identifier('assertInstanceOf');
 
         $fullyQualified = new FullyQualified($pureType->getClassName());