Skip to content

Update internal pixel gtag id#6554

Open
carlosabadia wants to merge 1 commit into
mainfrom
carlos/update-gtag-id
Open

Update internal pixel gtag id#6554
carlosabadia wants to merge 1 commit into
mainfrom
carlos/update-gtag-id

Conversation

@carlosabadia
Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested a review from a team as a code owner May 22, 2026 09:09
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026

Greptile Summary

This PR replaces the Google Analytics 4 measurement ID (G-4T7C8ZD9TR) with AW-18175470538 inside get_pixel_website_trackers. The new ID uses the AW- prefix, which belongs to a Google Ads property rather than a GA4 property.

  • The ID format change (G-AW-) means a Google Ads property ID is now passed to get_google_analytics_trackers, a function designed for GA4 measurement IDs; if the underlying implementation hard-codes GA4-specific behaviour this would silently stop collecting analytics events.
  • The existing gtag_report_conversion call already uses an AW- conversion ID, so if the intent is to fully migrate away from GA4 to a Google Ads-only setup, that should be made explicit in the code or PR description.

Confidence Score: 3/5

The change substitutes a GA4 measurement ID with a Google Ads ID in a function whose name and likely implementation are tied to GA4 analytics, which could silently break analytics collection.

The swap from a G- prefixed GA4 ID to an AW- prefixed Google Ads ID inside get_google_analytics_trackers introduces a semantic mismatch that may silently drop all website analytics events if the underlying function only configures GA4 tracking.

packages/reflex-site-shared/src/reflex_site_shared/telemetry/pixels.py — needs confirmation that get_google_analytics_trackers handles Google Ads (AW-) IDs correctly, or that the intent to remove GA4 analytics is deliberate.

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/telemetry/pixels.py Swaps the Google Analytics GA4 measurement ID (G-4T7C8ZD9TR) for a Google Ads property ID (AW-18175470538), which may not be compatible with get_google_analytics_trackers and would silently drop GA4 analytics collection.

Reviews (1): Last reviewed commit: "Update gtag id" | Re-trigger Greptile

"""
return [
*get_google_analytics_trackers(tracking_id="G-4T7C8ZD9TR"),
*get_google_analytics_trackers(tracking_id="AW-18175470538"),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Google Ads ID passed to Analytics tracker

The new ID AW-18175470538 uses the AW- prefix, which identifies a Google Ads property (conversion linker / remarketing tag), whereas the previous ID G-4T7C8ZD9TR was a GA4 Analytics measurement ID (G- prefix). Passing a Google Ads ID to get_google_analytics_trackers may silently drop pageview/analytics events since that function is likely configured specifically to emit gtag('config', ...) calls suitable for GA4. GA4 analytics collection would be lost entirely. If the intent is to replace GA4 with a Google Ads tag, a dedicated function or a rename of the call site would make the intent explicit and avoid the mismatch.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 22, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing carlos/update-gtag-id (b9b92fa) with main (d611a5d)

Open in CodSpeed

Copy link
Copy Markdown
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to validate this?

@carlosabadia
Copy link
Copy Markdown
Contributor Author

how to validate this?

Palash is gonna check this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants