Skip to content

Installer doesn't bootstrap config or path #6

Description

@lachlan2k

Issue or Bug

Description

The install.sh script doesn't ensure ~/.local/bin is in the users path, and doesn't create a config file by default.

When you first try to run the riptide client cli after installing, you may have the following experience. First, it can't find the program, then, when you specify the path to it, it indefnitely hangs:

image

I personally didn't have ~/.local/bin in my path on my dev vm, so I presumed the installer failed.

A quick strace reveals the program hangs because the config file doesn't exist:
image

Tasks/General Thoughts

  • Ensure a default config file is installed by install.sh.
  • If a config file isn't present, give a helpful error message instead of locking up.
  • The install script should detect if ~/.local/bin is in the users path. If it isn't, it should at the very least warn the user. It should also say "Hey you might wanna add export PATH="$PATH:~/.local/bin" to your shell RC" or whatever. Ideally, it should even offer a y/n prompt to do this.
    • Modifying the user's shell config without asking is a bit invasive, so I wouldn't advise this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions