Skip to content

AttachmentParent struct never created #160

Description

@mkatychev

It seems none of the default hooks/contructors ever pass down an AttachmentParent meaning that the AttachmentFormatterHook is (by default) unable to access the parent report.

pub fn format_inner(self) -> impl core::fmt::Display + core::fmt::Debug {
format_helper(
self.into_dynamic(),
|attachment, formatter| {
crate::hooks::attachment_formatter::display_attachment(attachment, None, formatter)
},
|attachment, formatter| {
crate::hooks::attachment_formatter::debug_attachment(attachment, None, formatter)
},
)
}

impl<'a, A: ?Sized> core::fmt::Display for ReportAttachmentRef<'a, A> {
fn fmt(&self, formatter: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
let report: ReportAttachmentRef<'_, Dynamic> = self.into_dynamic();
crate::hooks::attachment_formatter::display_attachment(report, None, formatter)
}
}
impl<'a, A: ?Sized> core::fmt::Debug for ReportAttachmentRef<'a, A> {
fn fmt(&self, formatter: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
let report: ReportAttachmentRef<'_, Dynamic> = self.into_dynamic();
crate::hooks::attachment_formatter::debug_attachment(report, None, formatter)
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions