ros2daemon also uses node logger to store log in the file system.#1237
Open
fujitatomoya wants to merge 1 commit into
Open
ros2daemon also uses node logger to store log in the file system.#1237fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
commented
May 24, 2026
Collaborator
Author
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde what do you think about this fix? i believe there is no downside even if we start the daemon in foreground.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
part of #1236.
with this, ros2daemon can also store log file and put the log data on /rosout topic.
Fixes #1236
Is this user-facing behavior change?
Not really, now user can see ros2daemon logfile in ros log directory.
Did you use Generative AI?
Yes, Claude Opus 4.7
Additional Information