Skip to content

Allow sending of metadata with sendFile#419

Open
samsont wants to merge 1 commit into
simplewebrtc:masterfrom
samsont:master
Open

Allow sending of metadata with sendFile#419
samsont wants to merge 1 commit into
simplewebrtc:masterfrom
samsont:master

Conversation

@samsont

@samsont samsont commented Apr 11, 2016

Copy link
Copy Markdown

When you send a file: added the ability to send metadata with the file. The functionality was already in place, just added a spot for the additional data.

If you send a file: added the ability to send metadata about the file. The functionality was already in place, just added a spot for the additional data.
@xdumaine

Copy link
Copy Markdown
Contributor

I like this. @latentflip?

@tgabi333

Copy link
Copy Markdown
Contributor

i would rather call metadata the passed parameter everywhere instead of additionalData

@samsont

samsont commented May 27, 2016

Copy link
Copy Markdown
Author

I agree with the comment on metadata. The challenge is that on the receiving side, there already is a variable called metadata. (https://github.com/otalk/filetransfer/blob/master/filetransfer.js) . There is a metadata.size and a metadata.name. I access the information I proposing to add as: metadeta.additionalData,

A simpler thing to do might be that instead of using what I wrote:
Peer.prototype.sendFile = function (file, metadata)
Instead to use
Peer.prototype.sendFile = function (file, additionalData)
to keep the same name all the way through.

If I made that change, might that be ok?

Thanks!

@tgabi333

tgabi333 commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

maybeadditionalInfo?

@fippo

fippo commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

I think its safe to call this metadata, this should not conflict with the use of that name in filetransfer?

@jayaprabhakar

Copy link
Copy Markdown

Any plans on merging this change? It has been two years, so I am curious. I want this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants