Skip to content

s/getSessionid/getSessionId/g for consistency with documentation#439

Open
buu700 wants to merge 1 commit into
simplewebrtc:masterfrom
buu700:master
Open

s/getSessionid/getSessionId/g for consistency with documentation#439
buu700 wants to merge 1 commit into
simplewebrtc:masterfrom
buu700:master

Conversation

@buu700

@buu700 buu700 commented May 29, 2016

Copy link
Copy Markdown

No description provided.

@xdumaine

Copy link
Copy Markdown
Contributor

I do prefer the corrected casing, though this would be a breaking change. @tgabi333 @fippo

@buu700

buu700 commented Jul 14, 2016

Copy link
Copy Markdown
Author

Should I update this to support both names so existing code isn't affected?

@xdumaine

xdumaine commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

Eek. I should have pulled this in for 3.0.0

@buu700

buu700 commented Jul 5, 2017

Copy link
Copy Markdown
Author

lol, you could always merge it and bump the version to 4.0 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants