Skip to content

Commit dd2872a

Browse files
committed
fix(helm): review round 1 — scoped example egress, in-tab secret note, copilot Job wording
- external-db example egress scopes to a placeholder database CIDR instead of to: [] (which allowed every destination on 5432, defeating the isolation the example teaches) - kubernetes.mdx cloud tabs state explicitly that they reuse the variables generated in the Installation block - Copilot migrations really do run as a Helm-hook Job — restore Job wording there (only the app migrations are an init container)
1 parent d7e1475 commit dd2872a

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

apps/docs/content/docs/en/platform/self-hosting/kubernetes.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ helm install sim ./helm/sim \
3838

3939
## Cloud-Specific Values
4040

41+
These commands reuse the `$BETTER_AUTH_SECRET`, `$ENCRYPTION_KEY`, `$INTERNAL_API_SECRET`, `$CRON_SECRET`, and `$POSTGRES_PASSWORD` variables generated in [Installation](#installation) above — run that block's `openssl` lines first in the same shell.
42+
4143
<Tabs items={['AWS EKS', 'Azure AKS', 'GCP GKE']}>
4244
<Tab value="AWS EKS">
4345
```bash

helm/sim/examples/values-external-db.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,11 @@ networkPolicy:
175175
# external DB on a different port (or off-cluster), add an egress rule.
176176
# `networkPolicy.egress` is a LIST of NetworkPolicy egress rules.
177177
egress:
178-
- to: []
178+
- to:
179+
# Scope to YOUR database's subnet — an empty `to:` would allow the pods
180+
# to reach ANY host on 5432, defeating the isolation this teaches.
181+
- ipBlock:
182+
cidr: 10.0.0.0/16 # replace with your database subnet or /32 host CIDR
179183
ports:
180184
- protocol: TCP
181185
port: 5432

helm/sim/values.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1674,9 +1674,10 @@ copilot:
16741674
secretKey: DATABASE_URL
16751675
url: ""
16761676

1677-
# Migration job configuration
1677+
# Migration job configuration (Copilot migrations run as a Helm-hook Job,
1678+
# unlike the app migrations which run as an init container)
16781679
migrations:
1679-
# Enable/disable the migrations init container
1680+
# Enable/disable the Copilot migrations Job
16801681
enabled: true
16811682

16821683
# Image configuration (same as server)

0 commit comments

Comments
 (0)