You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The XDR quoted on Stellar Transaction is protocol-20-era in several places. Surfaced while reviewing #2655, where the SorobanTransactionData reference link was pinned to a commit predating diskReadBytes. That one link is fixed; the rest of the page still needs a pass.
Missing case HOST_FUNCTION_TYPE_CREATE_CONTRACT_V2: CreateContractArgsV2 createContractV2;
CreateContractArgsV2 (adds SCVal constructorArgs<>) isn't documented at all, so contract constructors — protocol 22 — have no coverage here.
SorobanCredentials (#authorization-data)
Missing SOROBAN_CREDENTIALS_ADDRESS_V2 and SOROBAN_CREDENTIALS_ADDRESS_WITH_DELEGATES / SorobanAddressCredentialsWithDelegates. Relevant to smart accounts and delegated signers.
Shows SorobanAuthorizedContractFunction contractFn; and then defines that struct. It no longer exists in the protocol — the variant is InvokeContractArgs contractFn;.
The prose says "SorobanAuthorizedFunction has two variants"; there are three.
HashIDPreimage
Missing ENVELOPE_TYPE_SOROBAN_AUTHORIZATION_WITH_ADDRESS / sorobanAuthorizationWithAddress. The signature field description points readers at the plain ENVELOPE_TYPE_SOROBAN_AUTHORIZATION preimage only.
Stale reference pin
The [xdr] link for the HostFunction / InvokeHostFunctionOp block is still pinned to e372df9, a commit old enough that it names the op BumpFootprintExpirationOp. Deliberately left alone in Correct Soroban transaction resource, TTL, and SAC XDR references #2655: repointing it at v27.0 would only expose the CREATE_CONTRACT_V2 gap above. Bump it as part of this refresh.
Each struct edit needs matching prose, so this wants a protocol-accuracy review rather than a mechanical copy-paste from the .x file.
The XDR quoted on Stellar Transaction is protocol-20-era in several places. Surfaced while reviewing #2655, where the
SorobanTransactionDatareference link was pinned to a commit predatingdiskReadBytes. That one link is fixed; the rest of the page still needs a pass.Comparing against
v27.0/Stellar-transaction.x:HostFunction(#invokehostfunctionop)case HOST_FUNCTION_TYPE_CREATE_CONTRACT_V2: CreateContractArgsV2 createContractV2;CreateContractArgsV2(addsSCVal constructorArgs<>) isn't documented at all, so contract constructors — protocol 22 — have no coverage here.SorobanCredentials(#authorization-data)SOROBAN_CREDENTIALS_ADDRESS_V2andSOROBAN_CREDENTIALS_ADDRESS_WITH_DELEGATES/SorobanAddressCredentialsWithDelegates. Relevant to smart accounts and delegated signers.SorobanAuthorizedFunctionSOROBAN_AUTHORIZED_FUNCTION_TYPE_CREATE_CONTRACT_V2_HOST_FN.SorobanAuthorizedContractFunction contractFn;and then defines that struct. It no longer exists in the protocol — the variant isInvokeContractArgs contractFn;.SorobanAuthorizedFunctionhas two variants"; there are three.HashIDPreimageENVELOPE_TYPE_SOROBAN_AUTHORIZATION_WITH_ADDRESS/sorobanAuthorizationWithAddress. Thesignaturefield description points readers at the plainENVELOPE_TYPE_SOROBAN_AUTHORIZATIONpreimage only.Stale reference pin
[xdr]link for theHostFunction/InvokeHostFunctionOpblock is still pinned toe372df9, a commit old enough that it names the opBumpFootprintExpirationOp. Deliberately left alone in Correct Soroban transaction resource, TTL, and SAC XDR references #2655: repointing it atv27.0would only expose theCREATE_CONTRACT_V2gap above. Bump it as part of this refresh.Each struct edit needs matching prose, so this wants a protocol-accuracy review rather than a mechanical copy-paste from the
.xfile.