From 08562149feab89d4a50778a76e8f96cdf4d2bef7 Mon Sep 17 00:00:00 2001 From: Derek Passen Date: Fri, 5 Jun 2026 15:39:37 -0400 Subject: [PATCH] remove :on-complete from circuit breaker spec and allowed keys CircuitBreakerBuilder has no onComplete method; the key was accepted by spec validation but could never be wired to the underlying policy. --- src/diehard/circuit_breaker.clj | 2 +- src/diehard/spec.clj | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/diehard/circuit_breaker.clj b/src/diehard/circuit_breaker.clj index b7cdc78..3d54ed0 100644 --- a/src/diehard/circuit_breaker.clj +++ b/src/diehard/circuit_breaker.clj @@ -14,7 +14,7 @@ :fail-if :fail-on :fail-when - :on-open :on-close :on-half-open :on-complete}) + :on-open :on-close :on-half-open}) (defn circuit-breaker [opts] (u/verify-opt-map-keys-with-spec :circuit-breaker/circuit-breaker opts) diff --git a/src/diehard/spec.clj b/src/diehard/spec.clj index 22c5b7c..8f3a49e 100644 --- a/src/diehard/spec.clj +++ b/src/diehard/spec.clj @@ -104,7 +104,6 @@ (s/def :circuit-breaker/on-open fn?) (s/def :circuit-breaker/on-close fn?) (s/def :circuit-breaker/on-half-open fn?) -(s/def :circuit-breaker/on-complete fn?) (s/def :circuit-breaker/circuit-breaker (only-keys :opt-un [:circuit-breaker/fail-if @@ -121,7 +120,6 @@ :circuit-breaker/on-open :circuit-breaker/on-half-open :circuit-breaker/on-close - :circuit-breaker/on-complete :circuit-breaker/delay-ms :circuit-breaker/timeout-ms]))