Skip to content

[template] case mustache return handlebars compiler #329

Description

@isaac-pj

The package aframe-template-component in npm version 3.2.1

When i try to render mustache template an error is throwed out on console.

mustache.min.js:1 Uncaught (in promise) TypeError: Invalid template! Template should be a "string" but "function" was given as the first argument for mustache#render(template, view, partials)
    at Object.render (mustache.min.js:1:9011)
    at renderTemplate (index.js:109:23)
    at n.renderTemplate (index.js:78:28)

checking the index.js at line :184 i see that the case is wrongly returning handlebars compiler for mustache case

    case MUSTACHE: {
      return compileHandlebarsTemplate;
    }

I see that the problem was fixed on this commit 4d1a49b 6 years before, but the package was published in last 3 months and the bug there is.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions