feat: auto-generate transaction IDs for account and demo account creation

Author: victorycodedev

README.md

@@ -218,14 +218,15 @@ $response = $replicas->createReplica(
         'magic' => 123456,
         'region' => 'london',
     ],
-    transactionId: bin2hex(random_bytes(16))
 );
 
 if ($response->shouldRetry()) {
     echo "Replica creation accepted. Retry after: " . ($response->retryAfter() ?? 'not specified');
 }
 ```
 
+A transaction ID is auto-generated. Pass your own `transactionId` to retry an accepted request.
+
 Available methods:
 
 - `replicas(string $accountId)`
@@ -260,7 +261,6 @@ $response = $demoAccounts->createMT4DemoAccount(
         'serverName' => 'Example-Server',
         'keywords' => ['Example Broker Ltd'],
     ],
-    transactionId: bin2hex(random_bytes(16))
 );
 
 if ($response->isCreated()) {
@@ -272,6 +272,16 @@ if ($response->shouldRetry()) {
 }
 ```
 
+A transaction ID is auto-generated for you. You can also pass your own if you need to retry an accepted request:
+
+```php
+$response = $demoAccounts->createMT4DemoAccount(
+    'provisioning-profile-id',
+    [...],
+    transactionId: 'my-custom-32-char-transaction-id'
+);
+```
+
 Create a MetaTrader 5 demo account:
 
 ```php
@@ -287,7 +297,6 @@ $response = $demoAccounts->createMT5DemoAccount(
         'serverName' => 'Example-Server',
         'keywords' => ['Example Broker Ltd'],
     ],
-    transactionId: bin2hex(random_bytes(16))
 );
 ```
 

src/Resources/AccountManagement/Account.php

@@ -89,7 +89,7 @@ public function createConfigurationLink(string $accountId, ?int $ttlInDays = nul
 
     private function transactionHeader(?string $transactionId): array
     {
-        return $transactionId ? ['transaction-id' => $transactionId] : [];
+        return ['transaction-id' => $transactionId ?? bin2hex(random_bytes(16))];
     }
 
     private function apiVersionHeader(?int $apiVersion): array

src/Resources/AccountManagement/AccountReplica.php

@@ -24,10 +24,15 @@ public function createReplica(string $accountId, array $data, ?string $transacti
         return $this->http->postAction(
             "/users/current/accounts/{$accountId}/replicas",
             $data,
-            $transactionId ? ['transaction-id' => $transactionId] : []
+            $this->transactionHeader($transactionId)
         );
     }
 
+    private function transactionHeader(?string $transactionId): array
+    {
+        return ['transaction-id' => $transactionId ?? bin2hex(random_bytes(16))];
+    }
+
     public function updateReplica(string $accountId, string $replicaId, array $data): array|string|null
     {
         return $this->http->put("/users/current/accounts/{$accountId}/replicas/{$replicaId}", $data);

src/Resources/AccountManagement/DemoAccount.php

@@ -9,21 +9,26 @@ class DemoAccount
 {
     public function __construct(private readonly Http $http) {}
 
-    public function createMT4DemoAccount(string $profileId, array $data, string $transactionId): ActionResponse
+    public function createMT4DemoAccount(string $profileId, array $data, ?string $transactionId = null): ActionResponse
     {
         return $this->http->postAction(
             "/users/current/provisioning-profiles/{$profileId}/mt4-demo-accounts",
             $data,
-            ['transaction-id' => $transactionId]
+            $this->transactionHeader($transactionId)
         );
     }
 
-    public function createMT5DemoAccount(string $profileId, array $data, string $transactionId): ActionResponse
+    public function createMT5DemoAccount(string $profileId, array $data, ?string $transactionId = null): ActionResponse
     {
         return $this->http->postAction(
             "/users/current/provisioning-profiles/{$profileId}/mt5-demo-accounts",
             $data,
-            ['transaction-id' => $transactionId]
+            $this->transactionHeader($transactionId)
         );
     }
+
+    private function transactionHeader(?string $transactionId): array
+    {
+        return ['transaction-id' => $transactionId ?? bin2hex(random_bytes(16))];
+    }
 }

tests/AccountManagementTest.php

@@ -38,6 +38,18 @@
     expect($history[0]['request']->getHeaderLine('transaction-id'))->toBe('12345678901234567890123456789012');
 });
 
+it('auto-generates transaction id for account create when not provided', function (): void {
+    $history = [];
+    $metaapi = metaApiClientWithHistory([new Response(201, [], '{}')], $history);
+
+    $metaapi->accounts()->create(['name' => 'Demo']);
+
+    $transactionId = $history[0]['request']->getHeaderLine('transaction-id');
+    expect($transactionId)->not->toBeEmpty();
+    expect(strlen($transactionId))->toBe(32);
+    expect(ctype_xdigit($transactionId))->toBeTrue();
+});
+
 it('exposes accepted account creation retry metadata', function (): void {
     $metaapi = metaApiClientWithHistory([
         new Response(202, ['Retry-After' => '10'], '{"id":"account-id","state":"DRAFT"}'),
@@ -86,6 +98,18 @@
     expect($history[0]['request']->getHeaderLine('transaction-id'))->toBe('transaction-id');
 });
 
+it('auto-generates transaction id for replica create when not provided', function (): void {
+    $history = [];
+    $metaapi = metaApiClientWithHistory([new Response(201, [], '{}')], $history);
+
+    $metaapi->accountReplicas()->createReplica('account-id', ['magic' => 123456]);
+
+    $transactionId = $history[0]['request']->getHeaderLine('transaction-id');
+    expect($transactionId)->not->toBeEmpty();
+    expect(strlen($transactionId))->toBe(32);
+    expect(ctype_xdigit($transactionId))->toBeTrue();
+});
+
 it('exposes accepted account replica creation retry metadata', function (): void {
     $metaapi = metaApiClientWithHistory([
         new Response(202, ['Retry-After' => '15'], '{"id":"replica-id","state":"DRAFT"}'),

tests/DemoAccountTest.php

@@ -53,6 +53,30 @@
     expect($history[0]['request']->getHeaderLine('transaction-id'))->toBe('transaction-id-1234567890123456');
 });
 
+it('auto-generates transaction id for mt4 demo account when not provided', function (): void {
+    $history = [];
+    $metaapi = metaApiClientWithHistory([new Response(201, [], '{}')], $history);
+
+    $metaapi->demoAccounts()->createMT4DemoAccount('profile-id', []);
+
+    $transactionId = $history[0]['request']->getHeaderLine('transaction-id');
+    expect($transactionId)->not->toBeEmpty();
+    expect(strlen($transactionId))->toBe(32);
+    expect(ctype_xdigit($transactionId))->toBeTrue();
+});
+
+it('auto-generates transaction id for mt5 demo account when not provided', function (): void {
+    $history = [];
+    $metaapi = metaApiClientWithHistory([new Response(201, [], '{}')], $history);
+
+    $metaapi->demoAccounts()->createMT5DemoAccount('profile-id', []);
+
+    $transactionId = $history[0]['request']->getHeaderLine('transaction-id');
+    expect($transactionId)->not->toBeEmpty();
+    expect(strlen($transactionId))->toBe(32);
+    expect(ctype_xdigit($transactionId))->toBeTrue();
+});
+
 it('exposes accepted demo account creation retry metadata', function (): void {
     $metaapi = metaApiClientWithHistory([
         new Response(202, ['Retry-After' => '10'], '{"id":"request-id","state":"DRAFT"}'),