ModalDialog replacement in VideoJS10?

[JPustkuchen]

Hi,

looking at v10 code and documentation I was wondering if there's a replacement for ModalDialog which existed in previous versions of videoJS?
https://legacy.videojs.org/guides/modal-dialog/
https://docs.videojs.com/docs/api/modal-dialog.html

Is this planned to be integrated somehow or should it be solved in custom code where VideoJS is used?

Typically having a Dialog / Modal isn't that complicated, but there are points like

• auto-stopping the video when the modal closes
• auto-playing when the modal opens
• ...

that need integration in every implementation.

So I'd like to ask if there's a plan or best practice?

If it isn't and won't be integrated, maybe a documentation page informing about that and showing best practices would be super helpful!

Thank you so much!

[JPustkuchen]

Would be great to get a short statement from the videojs team, if a modal dialog will be a feature in 10.x or is out of scope now.
That would be super helpful.

We need it to plan the VideoJS Drupal module integration: https://www.drupal.org/project/videojs/issues/3616068#comment-16744210

[danrossi]

You have to make your own element / plugin. You can control playback with the "selectPlayback" helper method. Media events on the other hand have to be duplicated for both video tag and hls media, not universal so extra work. Listening to events on each element.

Its not concise info or informative enough but this is a start https://videojs.org/docs/framework/html/how-to/build-your-own-component

[mihar-22]

Hey, @JPustkuchen!

We have a generic dialog component, which we use for built-in error and alert dialogs as well. If you want to open the player in a modal after clicking a thumbnail, that setup is up to your application.

I also just noticed none of our dialog components have API reference pages. Working on a fix now!

I'll see if I can put together an example here on how that would be achieved with HTML and React.

[mihar-22]

I also noticed we don't have a public generic Dialog component so I'm working on getting that added #2384

[JPustkuchen]

Thank you all very much for the rapid feedback! Very much looking forward to that. And yes, would be great to have the documentation up to date, because it's really hard from an outside perspective to understand things.

Thank you!!