Skip to content

Commit 9d5c97c

Browse files
committed
Keep only local FineWeb and PolarSignals beyond the core SQL PR set
Move statpopgen and FineWeb on S3 to the extended label only, and test that `pr-full` covers every `pr` target. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KFeuTV21uQCX8GcNyZbKwf
1 parent 7993ae3 commit 9d5c97c

3 files changed

Lines changed: 23 additions & 7 deletions

File tree

‎bench-orchestrator/bench_orchestrator/ci_matrix/catalog.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"develop": "Every regular SQL benchmark at full target coverage.",
1616
"pr": "The quicker pull-request SQL benchmark matrix (action/bench-sql).",
1717
"pr-compact": "Pull-request SQL benchmarks for Vortex Compact plus Parquet controls.",
18-
"pr-all": "The PR and PR Compact benchmark matrices plus Clickbench Sorted (action/bench-all).",
18+
"pr-all": "The PR and PR Compact benchmark matrices plus extended-only default targets (action/bench-all).",
1919
"pr-full": "Every regular SQL benchmark at full PR target coverage (action/bench-sql-extended).",
2020
"nightly": "Large-scale SF=100 TPC-H on NVMe and S3 at default targets.",
2121
}
@@ -202,7 +202,6 @@
202202
scale_factor=100,
203203
local_dir="vortex-bench/data/statpopgen",
204204
runs={
205-
"pr": DUCKDB_DEFAULT,
206205
"pr-compact": COMPACT_DUCKDB,
207206
"pr-all": DUCKDB_STANDARD,
208207
"pr-full": DUCKDB_STANDARD,
@@ -231,7 +230,6 @@
231230
local_dir="vortex-bench/data/fineweb",
232231
remote_key="fineweb",
233232
runs={
234-
"pr": DEFAULT,
235233
"pr-compact": COMPACT,
236234
"pr-all": STANDARD,
237235
"pr-full": STANDARD,

‎bench-orchestrator/tests/test_matrix.py‎

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,15 @@
4242
"pr": tuple(
4343
benchmark_id
4444
for benchmark_id in REGULAR_IDS
45-
if benchmark_id not in {"clickbench-sorted-nvme", "tpch-s3-10", "appian-nvme", "vortex-queries"}
45+
if benchmark_id
46+
not in {
47+
"clickbench-sorted-nvme",
48+
"tpch-s3-10",
49+
"statpopgen",
50+
"fineweb-s3",
51+
"appian-nvme",
52+
"vortex-queries",
53+
}
4654
),
4755
"pr-compact": COMPACT_IDS,
4856
"pr-all": PR_ALL_IDS,
@@ -105,6 +113,14 @@ def test_pr_all_covers_focused_presets() -> None:
105113
assert set(cast("list[str]", source["data_formats"])) <= set(cast("list[str]", entry["data_formats"]))
106114

107115

116+
def test_pr_full_covers_pr() -> None:
117+
pr = {entry["id"]: entry for entry in _entries("pr")}
118+
pr_full = {entry["id"]: entry for entry in _entries("pr-full")}
119+
120+
for benchmark_id, entry in pr.items():
121+
assert _targets(entry) <= _targets(pr_full[benchmark_id])
122+
123+
108124
def test_resolver_rejects_empty_targets() -> None:
109125
benchmark = replace(
110126
CATALOG.benchmarks[0],

‎docs/developer-guide/benchmarking.md‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,14 +262,16 @@ Benchmarks run automatically on all commits to `develop` and can be run on-deman
262262
- **GPU compression** -- `action/bench-gpu-compress` runs the allow-listed Vortex decompression
263263
cases on a GPU runner.
264264
- **SQL** -- `action/bench-sql` runs the `pr` preset, a quick core subset of the SQL benchmarks
265-
that excludes `vortex-compact`, Clickbench Sorted, Appian, TPC-H SF=10 on S3, and Vortex queries.
265+
that excludes `vortex-compact`, Clickbench Sorted, Appian, statpopgen, FineWeb on S3, TPC-H SF=10
266+
on S3, and Vortex queries.
266267
- **SQL Extended** -- `action/bench-sql-extended` runs the `pr-full` preset: every regular SQL
267268
benchmark, including `vortex-compact` and DuckDB-format targets.
268269
- **SQL Compact** -- `action/bench-sql-compact` runs the `pr-compact` preset, which benchmarks
269270
`vortex-compact` plus Parquet control rows used to distinguish code changes from runner drift.
270271
- **All CPU benchmarks** -- `action/bench-all` runs random access, compression, string encoding,
271-
and the `pr-all` SQL preset, which combines the `pr` and `pr-compact` coverage, plus
272-
Clickbench Sorted, without repeating shared jobs. Do not combine it with other benchmark labels;
272+
and the `pr-all` SQL preset, which combines the `pr` and `pr-compact` coverage, plus the
273+
default targets of Clickbench Sorted, statpopgen, and FineWeb on S3, without repeating shared
274+
jobs. Do not combine it with other benchmark labels;
273275
GPU compression is the only exception.
274276

275277
All CI benchmarks run on dedicated instances with the `release_debug` profile and

0 commit comments

Comments
 (0)