Skip to content

Separate project-context discovery from display-only repository browsing#11921

Closed
moirahuang wants to merge 2 commits into
moira/remote-project-rulesfrom
moira/skills-degraded-fallback
Closed

Separate project-context discovery from display-only repository browsing#11921
moirahuang wants to merge 2 commits into
moira/remote-project-rulesfrom
moira/skills-degraded-fallback

Conversation

@moirahuang

@moirahuang moirahuang commented May 30, 2026

Copy link
Copy Markdown
Contributor

Description

  • Stack this follow-up above Support remote project rules through repo metadata standing results #11460, which now owns normal direct project-rule discovery and the typed remote project-rule snapshot transport.
  • Keep repository-wide metadata authoritative: indexing failures remain failures rather than shallow successful trees, while lazy display trees provide separate local and remote browsing recovery.
  • Route local project skills and project rules through authoritative metadata when indexing succeeds and filesystem fallback only after authoritative indexing fails; extend project-rule publication with failed-index fallback without reintroducing normal tree-backed discovery.
  • Publish and consume typed remote project-skill replacement snapshots, while preventing display-only remote file-tree snapshots from becoming a project-context source.
  • Align production-style SkillManager test fixtures with its RemoteServerManager runtime-source subscription dependency exposed by the restack.

Linked Issue

No linked issue was provided for this stacked draft follow-up.

Testing

  • ./script/format

  • cargo test -p warp --lib ai::agent_sdk::driver::tests::split_loading_env_loads_all_global_loads_subset -- --nocapture

  • cargo test -p warp --lib ai::skills -- --nocapture

  • cargo test -p warp --lib metadata_project_rules

  • cargo test -p ai --features local_fs project_context

  • cargo test -p warp --lib remote_server::server_model::tests

  • cargo test -p warp --lib skill_watcher

  • ./script/presubmit

  • I have manually tested my changes locally with ./script/run (not run; focused model, watcher, daemon, fixture-regression, and full presubmit validation were run for this branch).

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Agent Artifacts

Co-Authored-By: Oz oz-agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label May 30, 2026
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch 4 times, most recently from 356c1d5 to b7ca2b3 Compare May 30, 2026 01:50
@moirahuang moirahuang force-pushed the moira/skills-ui-output-locations branch 2 times, most recently from f6b5f12 to 8ad69d3 Compare May 31, 2026 06:41
@moirahuang moirahuang force-pushed the moira/skills-degraded-fallback branch from 3cfbd5a to aac7b14 Compare May 31, 2026 06:41

moirahuang commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@moirahuang moirahuang changed the base branch from moira/skills-ui-output-locations to graphite-base/11921 May 31, 2026 07:36
@moirahuang moirahuang force-pushed the moira/skills-degraded-fallback branch from aac7b14 to 773afbf Compare May 31, 2026 08:07
@moirahuang moirahuang changed the title Handle degraded local project skill fallback Separate project skill discovery from display-only repository browsing May 31, 2026
@moirahuang moirahuang force-pushed the graphite-base/11921 branch from 8ad69d3 to f7e2747 Compare May 31, 2026 17:54
@moirahuang moirahuang force-pushed the moira/skills-degraded-fallback branch from 773afbf to d213400 Compare May 31, 2026 17:54
@moirahuang moirahuang changed the base branch from graphite-base/11921 to moira/remote-project-rules May 31, 2026 17:54
@moirahuang moirahuang changed the title Separate project skill discovery from display-only repository browsing Separate project-context discovery from display-only repository browsing May 31, 2026
moirahuang and others added 2 commits May 31, 2026 18:28
Co-Authored-By: Oz <oz-agent@warp.dev>
@moirahuang moirahuang force-pushed the moira/skills-degraded-fallback branch from d213400 to 87fde4c Compare June 1, 2026 02:41
@moirahuang moirahuang force-pushed the moira/remote-project-rules branch 2 times, most recently from 37e2ec4 to c6aea5d Compare June 1, 2026 07:18
@moirahuang

Copy link
Copy Markdown
Contributor Author

Superseded by #12047 and the revised stack design. Project-context discovery now moves through the foundational authoritative repo-metadata query PR, and project rules will be restacked above that foundation separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant