feat: add VPM update notification#2
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a048f36456
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (_routine.Current is IEnumerator nestedRoutine) | ||
| _nested = nestedRoutine; |
There was a problem hiding this comment.
Handle AsyncOperation yields in editor coroutine runner
EditorCoroutine.Update only pauses for yielded values that implement IEnumerator, but GetLatestVersionCoroutine yields request.SendWebRequest() (a UnityWebRequestAsyncOperation). Because that yield is ignored, _routine.MoveNext() runs again on the next editor tick before the request completes, so request.result is often still InProgress and the code reports a failed update check even when the network call would succeed. This makes automatic/manual update checks unreliable in normal latency conditions.
Useful? React with 👍 / 👎.
a048f36 to
c3ab590
Compare
Summary
https://vpm.32ba.net/api/packages/<package>/latest/version.metafiles with unique GUIDs for all new assetsVerification
curl.csfile has a matching.metafile