Skip to content

feat: add VPM update notification#2

Open
yuki-maruyama wants to merge 1 commit into
mainfrom
feat/vpm-update-notification
Open

feat: add VPM update notification#2
yuki-maruyama wants to merge 1 commit into
mainfrom
feat/vpm-update-notification

Conversation

@yuki-maruyama

@yuki-maruyama yuki-maruyama commented May 8, 2026

Copy link
Copy Markdown
Member

Summary

  • Add an editor update checker that calls https://vpm.32ba.net/api/packages/<package>/latest/version
  • Show an update dialog when a newer VPM version is available
  • Add Unity .meta files with unique GUIDs for all new assets

Verification

  • Verified every target package ID returns the expected latest version from the VPM API with curl
  • Verified every added .cs file has a matching .meta file
  • Verified generated Unity GUIDs are unique across the checked repositories
  • Verified no manual update-check menu item remains in the added update notification code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a048f36456

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +199 to +200
if (_routine.Current is IEnumerator nestedRoutine)
_nested = nestedRoutine;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Handle AsyncOperation yields in editor coroutine runner

EditorCoroutine.Update only pauses for yielded values that implement IEnumerator, but GetLatestVersionCoroutine yields request.SendWebRequest() (a UnityWebRequestAsyncOperation). Because that yield is ignored, _routine.MoveNext() runs again on the next editor tick before the request completes, so request.result is often still InProgress and the code reports a failed update check even when the network call would succeed. This makes automatic/manual update checks unreliable in normal latency conditions.

Useful? React with 👍 / 👎.

@yuki-maruyama
yuki-maruyama force-pushed the feat/vpm-update-notification branch from a048f36 to c3ab590 Compare May 8, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant