Add utility to reshard TFDS dataset for large scale training#3789
Merged
copybara-service[bot] merged 1 commit intomainfrom May 1, 2026
Merged
Add utility to reshard TFDS dataset for large scale training#3789copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
aireenmei
reviewed
May 1, 2026
|
🤖 Hi @shuningjin, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
This Pull Request introduces a valuable utility for resharding TFDS datasets, which is critical for maintaining efficient dataloading performance in large-scale training environments (e.g., matching shard count to host count). The implementation is well-structured, leverages multiprocessing effectively, and correctly updates the dataset metadata.
🔍 General Feedback
- The use of
raw_bytesreading and theround-robindistribution strategy into target shards is efficient and helps ensure a balanced distribution of data. - The automatic adjustment of
num_workersto be a factor ofnum_shardsis a clever way to maintain deterministic shard ownership per worker and avoid write collisions. - Overall, the code is high quality and follows good practices for data processing scripts.
aireenmei
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a utility to reshard TFDS dataset for large scale training, b/508024540.
Tests
Local conversation - example log
Before this change:
Tokens/s/device: 80-90per step linkAfter this change:
Tokens/s/device: 600-700per step linkFor training loss:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.