ADD: Radar-vs-Xradar compatibility test matrix - #1874
Draft
mgrover1 wants to merge 7 commits into
Draft
Conversation
… projection_proj/write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1873 — this branch is stacked on it; only the last commit (
tests/xradar/test_compat_matrix.py) is new. Will rebase and mark ready once #1873 merges.Adds a parametrized suite asserting numerical equality between a classic
Radarand itsXradarequivalent (built from one synthetic volume written to CfRadial and read back through both paths) acrosscalculate_velocity_texture, SNR retrieval,despeckle_field,calc_zdr_offset,GateFilter/add_filter, iterators/slices, RHI handling,grid_from_radars, andXgrid(to_xarray,add_field,get_point_longitude_latitude).This is the regression gate for the accessor: incompatibilities fail here instead of surfacing as user bug reports (cf. #1713, #1553, #1642). During development the matrix already caught the masked-array and RHI defects fixed in #1873.
Note: the fixture is synthetic because the two read paths show reader-level ray misalignment on real files — worth its own issue.
Tests: 16 passed (~35 s).