[Scala 3] restore SimpleClassName.materialize#862
Open
halotukozak wants to merge 3 commits into
Open
Conversation
halotukozak
changed the title
halotukozak
changed the title
- Replace ??? stub with inline implicit def + materializeImpl quoted macro
- Cribbed from fork master MiscMacros.materializeSimpleClassName: TypeRepr.of[T].dealias.typeSymbol.name.stripSuffix("$")
- Macro impl colocated in SimpleClassName.scala (private def materializeImpl)
Covers: String, List[Int], nested case class. All 3 tests pass.
- Drop SimpleClassName.scala:8 row from Backlog section - Total tags 155 (base was inconsistently 155 vs actual 156; now 155 in both)
halotukozak
force-pushed
the
02-04-class-name
branch
from
f24e39f to
df57af0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
SimpleClassName.materialize[T]via Scala 3 inline implicit def +TypeRepr.of[T].dealias.typeSymbol.name.stripSuffix("$"). Macro impl colocated as a private def inSimpleClassName.scala.Changes
SimpleClassName.materializenow resolves at compile-time (was???stub).SimpleClassNameTest(3 smoke tests: String, List[Int], nested case class).Verify
sbt 'commons-core/compile ;commons-core/Test/compile ;scalafmtCheckAll ;scalafmtSbtCheck'green.sbt 'commons-core/testOnly *SimpleClassNameTest': 3/3 pass.