[Scala 3] delete Implicits object (covered by summon[T])#867
Open
halotukozak wants to merge 4 commits into
Open
[Scala 3] delete Implicits object (covered by summon[T])#867halotukozak wants to merge 4 commits into
halotukozak wants to merge 4 commits into
Conversation
Separates the still-useful ImplicitNotFound sealed trait + companion from the to-be-deleted Implicits object. Pure extraction — semantics unchanged.
Implicits.infer / inferNonMacro were Scala 2 macro helpers. Scala 3 summon[T] + @implicitNotFound on using params replace the use case. 0 callers in tree (git grep verified). ImplicitNotFound moved to its own file in prior commit. User directive 2026-06-01: outright delete, do NOT deprecate (overrides fork commit 50272b2).
Records removal of com.avsystem.commons.misc.Implicits in §1; points downstream consumers to scala.compiletime.summon[T]. Notes that ImplicitNotFound sealed trait is preserved in its own file (same package, no caller-visible change).
ImplicitNotFound was a Scala 2 hack where the @implicitNotFound message
was itself resolved via implicit search, enabling composed error messages
(#{...} interpolation). No Scala 3 equivalent — @implicitNotFound is
native but message composition via implicit search is not.
Delete the sealed trait and its diagnostic-only dependents:
MetadataCompanion.Lazy.notFound, BoundedMetadataCompanion.Lazy.notFound,
AsRaw.notFoundForTry, AsReal.notFoundForTry. These only customized
compiler error messages — functionality unaffected. ImplicitNotFoundTest
deleted. Documented in MIGRATION.md.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
com.avsystem.commons.misc.Implicitsobject outright (was Scala 2 macro helpersinfer/inferNonMacro, both Phase-1 stubbed). Scala 3scala.compiletime.summon[T]+@implicitNotFoundonusingparams replace the use case. 0 callers in tree.ImplicitNotFoundsealed trait + companion — separate concern (custom error-message machinery) — extracted to its own filecom/avsystem/commons/misc/ImplicitNotFound.scala. Same package; no caller-visible change.Scope
core/src/main/scala/com/avsystem/commons/misc/Implicits.scalacore/src/main/scala/com/avsystem/commons/misc/ImplicitNotFound.scala(extracted verbatim)Acceptance
git ls-files .../Implicits.scala | wc -l→ 0git ls-files .../ImplicitNotFound.scala | wc -l→ 1git grep -nE '\bImplicits\.' -- '*.scala'→ 0 hitssbt compile + Test/compile + scalafmtCheckAllgreenUser directive 2026-06-01: outright delete, do NOT deprecate (overrides fork commit
50272b26 fix(scala-3): Implicits.infer real impl).Slice: 3.5 of Phase 3 (Scala 3 syntax modernization)
Merge order: Independent — can land any time (no overlap with 3.1/3.2/3.3/3.4)
Depends on: none
Base branch: upstream/scala-3