[visheshupadhyay]

Fixes #2097 and #2098

[gemini-code-assist]

Code Review

This pull request updates the custom redirect strategy to validate and only follow secure HTTPS redirects to Adyen domains for all redirect status codes, rather than restricting this check to 308 status codes. The tests have been updated and expanded to cover 307 redirects and non-HTTPS scenarios. Feedback suggests improving the host validation in isVerifyLocation to correctly handle bare domains and hostnames with a trailing dot.

[ashwaniarya-adyen]

#2098
#2097
fixes these

[ashwaniarya-adyen]

Hey @visheshupadhyay, thanks for the PR! The https check and validating all redirects instead of just 308 look good.

One small thing, could you revert the changes from the Gemini bot comment (allowing bare adyen.com / adyenpayments.com and stripping the trailing dot, plus the test for it)? All our APIs run on subdomains (*.adyen.com / *.adyenpayments.com), never on the bare domain, so we'd rather keep the original .endsWith(".adyen.com") || .endsWith(".adyenpayments.com") check as-is.

Once that's reverted, happy to merge!

[visheshupadhyay]

Thanks @ashwaniarya-adyen for the clarification. I reverted the bare-domain and trailing-dot handling, added negative coverage for those cases, and kept the HTTPS validation for all redirects. The branch is updated and the tests pass.

Build Run

Test Run

[ashwaniarya-adyen]

Thanks @ashwaniarya-adyen for the clarification. I reverted the bare-domain and trailing-dot handling, added negative coverage for those cases, and kept the HTTPS validation for all redirects. The branch is updated and the tests pass.

Build Run

```shell Test Run ```

Thanks for the quick update @visheshupadhyay! Could you just run mvn spotless:apply and push?

[visheshupadhyay]

Hi @ashwaniarya-adyen,

I've applied the requested Spotless formatting changes and pushed them in commit 04484c1.
The earlier redirect validation feedback has also been addressed, including preserving the original Adyen subdomain restrictions.
Could you please take another look when you have a chance? Let me know if anything else needs to be adjusted.

Thanks again for your review!