Repository navigation
[tapi] Code generation: update services and models - #2105
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the auto-generated Adyen Terminal API models, which includes deleting several classes (such as CardHolderPIN and PerformedTransaction), changing sensitive data fields from String to byte[], and converting various identifier fields from Integer to String. However, a critical issue was identified where multiple financial amount fields were changed from BigDecimal to Double, which introduces floating-point precision risks and should be reverted.
|
|
||
| public static final String JSON_PROPERTY_REQUESTED_AMOUNT = "RequestedAmount"; | ||
| private BigDecimal requestedAmount; | ||
| private Double requestedAmount; |
There was a problem hiding this comment.
Using Double for representing monetary or financial amounts introduces floating-point precision issues. Financial fields should use BigDecimal to guarantee precision and avoid rounding errors during calculations. This change from BigDecimal to Double across multiple model files appears to be a regression in the OpenAPI generator configuration or type mappings.
c2c90a3 to
2767a67
Compare
2767a67 to
ce3dbdc
Compare
This PR contains the automated changes for the
tapiservice.Adyen/adyen-openapi@638b69a
The commit history of this PR reflects the
adyen-openapicommits that have been applied.