Repository navigation
[softposconfiguration] Code generation: update services and models - #2106
AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the auto-generated Java SDK models and services for the SoftPOS configuration API (v3). The feedback highlights a potential naming conflict with an existing SessionAuthenticationApi class in another package, suggesting a rename to avoid developer confusion. Additionally, it is recommended to use the defined API_VERSION constant in SessionAuthenticationApi instead of hardcoding the version in the base URL.
| import com.adyen.service.resource.Resource; | ||
| import java.io.IOException; | ||
|
|
||
| public class SessionAuthenticationApi extends Service { |
There was a problem hiding this comment.
There is already an existing SessionAuthenticationApi class in the com.adyen.service.sessionauthentication package. Having another class with the exact same name SessionAuthenticationApi in com.adyen.service.softposconfiguration will cause naming conflicts and confusion for developers importing these classes. Consider renaming the tag in the OpenAPI specification (e.g., to SoftPosSessionAuthentication or SoftPosCertificate) to generate a unique class name like SoftPosSessionAuthenticationApi or SoftPosCertificateApi.
| */ | ||
| public SessionAuthenticationApi(Client client) { | ||
| super(client); | ||
| this.baseURL = createBaseURL("https://softposconfig-test.adyen.com/softposconfig/v3"); |
There was a problem hiding this comment.
Instead of hardcoding the version v3 in the base URL string, use the API_VERSION constant. This ensures consistency and makes future version updates easier and less error-prone.
| this.baseURL = createBaseURL("https://softposconfig-test.adyen.com/softposconfig/v3"); | |
| this.baseURL = createBaseURL("https://softposconfig-test.adyen.com/softposconfig/v" + API_VERSION); |
ea81f07 to
a64036c
Compare
|
This PR contains the automated changes for the
softposconfigurationservice.Adyen/adyen-openapi@638b69a
The commit history of this PR reflects the
adyen-openapicommits that have been applied.