Skip to content

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NarrowsProjects wants to merge 5 commits into
base: main
Choose a base branch
from

feat: change all filters that have only ObservableBasedSelectionDropd…

bc70145
Select commit
Loading
Failed to load commit list.
Open

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model #2143

feat: change all filters that have only ObservableBasedSelectionDropd…
bc70145
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 6, 2026 in 0s

45.92% (-0.03%) compared to ca5d12b

View this Pull Request on Codecov

45.92% (-0.03%) compared to ca5d12b

Details

Codecov Report

❌ Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.92%. Comparing base (ca5d12b) to head (bc70145).

Files with missing lines Patch % Lines
...blic/components/common/selection/SelectionModel.js 0.00% 17 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js 0.00% 9 Missing ⚠️
.../Filters/common/filters/ProcessedTextInputModel.js 0.00% 5 Missing ⚠️
...ponents/Filters/RunsFilter/EorReasonFilterModel.js 0.00% 4 Missing ⚠️
.../Filters/RunsFilter/MultiCompositionFilterModel.js 0.00% 4 Missing ⚠️
...s/common/filters/NumericalComparisonFilterModel.js 0.00% 4 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 4 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 3 Missing ⚠️
...ic/components/Filters/RunsFilter/GaqFilterModel.js 0.00% 3 Missing ⚠️
...nts/Filters/RunsFilter/RunDefinitionFilterModel.js 0.00% 3 Missing ⚠️
... and 14 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
- Coverage   45.95%   45.92%   -0.03%     
==========================================
  Files        1036     1035       -1     
  Lines       17155    17166      +11     
  Branches     3118     3124       +6     
==========================================
  Hits         7883     7883              
- Misses       9272     9283      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov