Skip to content

[PWGCF] Update lambdaR2Correlation.cxx#15925

Draft
yashpatley wants to merge 8 commits intoAliceO2Group:masterfrom
yashpatley:lambda-r2-update
Draft

[PWGCF] Update lambdaR2Correlation.cxx#15925
yashpatley wants to merge 8 commits intoAliceO2Group:masterfrom
yashpatley:lambda-r2-update

Conversation

@yashpatley
Copy link
Copy Markdown
Contributor

@yashpatley yashpatley commented Apr 22, 2026

  1. Removed the Matching Efficiency Correction
  2. Added lambda mass selection

@yashpatley
[PWGCF]: Update lambdaR2Correlation.cxx
8028510 
1. Removed the Matching Efficiency Correction
2. Added lambda mass selection
@github-actions github-actions Bot added the pwgcf label Apr 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026 •
edited
Loading

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [PWGCF]: Update lambdaR2Correlation.cxx [PWGCF] Update lambdaR2Correlation.cxx Apr 22, 2026
wenyaCern
wenyaCern previously approved these changes Apr 22, 2026
View reviewed changes
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 22, 2026

Error while checking build/O2Physics/o2 for 8028510 at 2026-04-22 23:46:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/lambdaR2Correlation.cxx:23:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera requested changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@vkucera vkucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yashpatley

  • You are reverting fixes of the includes. Pay attention to rebasing properly.
  • You apparently opened a PR without even compiling it.

@wenyaCern You approved the PR despite the obviously wrong modifications of includes.

@vkucera vkucera marked this pull request as draft April 22, 2026 22:23
@yashpatley
Copy link
Copy Markdown
Contributor Author

yashpatley commented May 5, 2026

@vkucera
Sorry for the inconvenience for the last PR.
I have updated the requested changes, but it seems that the O2Physics build is still remaining. It has been like this for past week. Let me know what to do.
Thanks.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 5, 2026

@vkucera Sorry for the inconvenience for the last PR. I have updated the requested changes, but it seems that the O2Physics build is still remaining. It has been like this for past week. Let me know what to do. Thanks.

You have not. You are still breaking the includes.

@yashpatley yashpatley marked this pull request as ready for review May 5, 2026 16:02
@yashpatley
[PWGCF]: Update lambdaR2Correlation.cxx
04e349a 
Reverted the changes in the include.
@alibuild alibuild mentioned this pull request May 5, 2026
Closed
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 5, 2026

Error while checking build/O2Physics/o2 for 04e349a at 2026-05-05 18:15:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TwoParticleCorrelations/Tasks/lambdaR2Correlation.cxx:52:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

@vkucera vkucera marked this pull request as draft May 5, 2026 16:20
yashpatley added 2 commits May 5, 2026 18:23
@yashpatley
[PWGCF]: Update lambdaR2Correlation.cxx
c8eeac6 
1. Reverted the include
2. Added Kaon table for Lambda-Kaon correlations
3. Modified the correction method
@yashpatley
Update lambdaR2Correlation.cxx
d29dae3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera requested changes

@wenyaCern wenyaCern wenyaCern left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yashpatley @alibuild @vkucera @wenyaCern