Cherry-pick: Fix: system.databases always shows data lake catalog databases#1690
Open
zvonand wants to merge 1 commit intoantalya-26.1from
Open
Cherry-pick: Fix: system.databases always shows data lake catalog databases#1690zvonand wants to merge 1 commit intoantalya-26.1from
zvonand wants to merge 1 commit intoantalya-26.1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from ClickHouse#103444.
Fix: system.databases always shows data lake catalog databases
system.databasesnow lists data lake catalog databases regardless of theshow_data_lake_catalogs_in_system_tablessetting.The setting exists to prevent accidental expensive calls to remote catalog services (e.g. listing tables or columns). Knowing that a catalog database exists, however, requires no remote call — the
DatabaseCatalogalready keeps it in local memory. Hiding the database insystem.databasesbased on that setting was inconsistent withSHOW DATABASES(which always showed catalogs since ClickHouse#89914) and confusing for users.Changes:
StorageSystemDatabases::fillDatanow passeswith_datalake_catalogs = trueunconditionally.InterpreterShowTablesQuery::executeno longer needs to force the setting forSHOW DATABASES(the rewrite tosystem.databasesalready returns the right result). The HACK is retained only forSHOW TABLES FROM <datalake_catalog>which still needs it.test_database_glueintegration test to assert thatsystem.databasesshows the catalog even with the setting off.Followup to: ClickHouse#89914
Changelog category (leave one):
Changelog entry
SELECT * FROM system.databasesnow always lists data lake catalog databases regardless of theshow_data_lake_catalogs_in_system_tablessetting. Previously they were hidden by default, which was inconsistent withSHOW DATABASESthat always showed them.