Fix .NET SDK version pin and add CI workflow#2
Conversation
Co-authored-by: AnthonyDegroote <13833439+AnthonyDegroote@users.noreply.github.com> Agent-Logs-Url: https://github.com/AnthonyDegroote/SoftwareCraftLab/sessions/5eaafa2b-527d-45fe-8210-b189cd5d9147
There was a problem hiding this comment.
Pull request overview
Fixes a broken .NET SDK pin that prevented dotnet from working, and introduces a basic GitHub Actions CI pipeline to restore/build/test on pushes and PRs targeting main.
Changes:
- Update
global.jsonSDK version pin from10.0.201to10.0.102. - Add a new GitHub Actions workflow to run
dotnet restore,dotnet build, anddotnet testonubuntu-latest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| global.json | Updates the pinned .NET SDK version to a working version. |
| .github/workflows/ci.yml | Adds CI workflow to automatically restore/build/test on pushes/PRs to main. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '10.0.x' |
There was a problem hiding this comment.
The CI installs .NET using dotnet-version: '10.0.x', which can drift from the pinned global.json SDK (10.0.102). That reduces reproducibility and can mask SDK-specific regressions. Consider installing the exact SDK from global.json (e.g., global-json-file: global.json) or pinning dotnet-version to 10.0.102 so local and CI builds use the same toolchain.
| dotnet-version: '10.0.x' | |
| global-json-file: global.json |
global.jsonpinned SDK10.0.201which doesn't exist in the environment, makingdotnetentirely non-functional. No CI pipeline existed to catch this or future regressions.Changes
global.json— bump pinned version10.0.201→10.0.102(latest available .NET 10 SDK);rollForward: latestFeatureunchanged.github/workflows/ci.yml— new GitHub Actions workflow: restore → build → test on every push/PR tomain, scoped tocontents: read