Skip to content

esphome.yaml: Tidy boot action whitespace#109

Merged
bharvey88 merged 1 commit into
ApolloAutomation:betafrom
gdt:tidy/boot-actions
Jul 7, 2026
Merged

esphome.yaml: Tidy boot action whitespace#109
bharvey88 merged 1 commit into
ApolloAutomation:betafrom
gdt:tidy/boot-actions

Conversation

@gdt

@gdt gdt commented Jul 7, 2026

Copy link
Copy Markdown

Make the single action a list of one action, rather than an action not in a list. This is semantically identical, and greatly reduces diffs among the 3 config files.

Version: 26.6.10.1

What does this implement/fix?

Moves a single boot action into a list, to reduce textual diffs with Factory which has a list of two actions.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally (base and Factory)
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • New Features
    • Added a managed HTTP-based firmware update option (including firmware manifest download) alongside the existing OTA method, with SSL verification and safe mode enabled.
    • Expanded air-quality LED controls: brightness slider, selectable LED source (Off/NowCast AQI/CO2/VOC Index), automatic color/brightness updates, plus a CO2 auto-calibration toggle.
  • Bug Fixes
    • Prevent Sleep now only allows deep sleep when OTA mode is off.
  • Style
    • Updated ESPHome minimum version and refreshed boot/update configuration formatting.
  • Chores
    • Updated build/release automation to produce both Factory and BLE firmware variants and improved release note formatting.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a7a5fdef-4f15-4cf1-9fcf-5f4effd0f272

📥 Commits

Reviewing files that changed from the base of the PR and between 8957c4f and e8fd0b0.

📒 Files selected for processing (9)
  • .github/release-drafter.yml
  • .github/workflows/autoassign.yml
  • .github/workflows/build.yml
  • .github/workflows/ci.yml
  • .github/workflows/label-check.yml
  • Integrations/ESPHome/AIR-1.yaml
  • Integrations/ESPHome/AIR-1_BLE.yaml
  • Integrations/ESPHome/AIR-1_Factory.yaml
  • Integrations/ESPHome/Core.yaml

Walkthrough

The PR updates ESPHome firmware configuration for OTA/update behavior, boot handling, and air-quality LED control, and adjusts GitHub release, build, and workflow settings. It also adds a new label-check workflow and narrows CI permissions.

Changes

ESPHome firmware changes

Layer / File(s) Summary
Core LED and sleep controls
Integrations/ESPHome/Core.yaml
Version and device text substitutions change, new air-quality LED brightness and source controls are added, sensor updates feed LED updates, prevent-sleep behavior is refined, and LED update/restore scripts are introduced.
Device OTA and boot wiring
Integrations/ESPHome/AIR-1.yaml, Integrations/ESPHome/AIR-1_BLE.yaml, Integrations/ESPHome/AIR-1_Factory.yaml
ESPHome minimum versions are raised, boot handlers are reformatted, and OTA/update configuration now uses http_request, safe_mode, manifest-driven firmware updates, and Wi-Fi connect hooks.

GitHub automation changes

Layer / File(s) Summary
Release and build wiring
.github/release-drafter.yml, .github/workflows/build.yml
Release note formatting changes and the build workflow now include BLE firmware output alongside the existing factory target.
Workflow triggers and permissions
.github/workflows/autoassign.yml, .github/workflows/ci.yml, .github/workflows/label-check.yml
Auto-assign switches to pull_request_target, CI permissions are reduced, and a new label-check workflow delegates to a reusable workflow.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

Suggested reviewers: TrevorSchirmer

Poem

I hopped through configs, light and bright,
Tweaked firmware paths and workflow night.
LEDs now dance by sensor lore,
And build steps carry BLE once more.
A tidy burrow, snug and tight. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the formatting-focused ESPHome boot action change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch tidy/boot-actions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Make the single action a list of one action, rather than an action not
in a list.  This is semantically identical, and greatly reduces diffs
among the 3 config files.
@bharvey88
bharvey88 force-pushed the tidy/boot-actions branch from 8957c4f to e8fd0b0 Compare July 7, 2026 20:09
@bharvey88
bharvey88 changed the base branch from main to beta July 7, 2026 20:10
@bharvey88

Copy link
Copy Markdown
Contributor

Thanks for this. List-form on_boot also merges more predictably when configs get layered, so this helps beyond readability.

Housekeeping notes: product firmware PRs land on beta (main gets synced from beta at release), so I rebased your branch onto beta and retargeted the PR. Beta's BLE file doesn't have the firmware version publish action yet, so the rebased commit keeps beta's content, just converted to list form. For future PRs, branching from beta will save you the rebase.

@bharvey88
bharvey88 merged commit 90834f5 into ApolloAutomation:beta Jul 7, 2026
1 check was pending
@gdt
gdt deleted the tidy/boot-actions branch July 8, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants