Skip to content

Buffering#47

Merged
TrevorSchirmer merged 2 commits into
betafrom
Buffering
Jul 8, 2026
Merged

Buffering#47
TrevorSchirmer merged 2 commits into
betafrom
Buffering

Conversation

@TrevorSchirmer

@TrevorSchirmer TrevorSchirmer commented Jul 8, 2026

Copy link
Copy Markdown
Member

Version:

What does this implement/fix?

  • Improvements for buffering

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • New Features

    • Updated the device firmware version.
    • Added improved audio handling for media and announcements.
  • Bug Fixes

    • Enforced PSRAM availability at startup to prevent unsupported boots.
    • Increased audio buffering to improve playback stability and reduce interruptions.
  • Refactor

    • Reworked the audio resampling path to use separate processing streams for media and announcements.

@github-actions github-actions Bot added the bugfix Something isn't working label Jul 8, 2026
@github-actions github-actions Bot requested a review from bharvey88 July 8, 2026 23:33
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 92b236a9-8e8d-4c23-88a5-26d563c2d834

📥 Commits

Reviewing files that changed from the base of the PR and between 18c1061 and 6e14e4b.

📒 Files selected for processing (2)
  • Integrations/ESPHome/Core.yaml
  • index.html

Walkthrough

This PR updates Integrations/ESPHome/Core.yaml: bumps the firmware substitution version, enforces PSRAM presence at boot via ignore_not_found: false, replaces the shared media resampler with separate announcement/media resamplers, shifts task stack placement to internal RAM, and adjusts media_source buffer sizes and decode memory settings.

Changes

ESPHome Core Config Update

Layer / File(s) Summary
Firmware version and PSRAM enforcement
Integrations/ESPHome/Core.yaml
Firmware version substitution bumped from 26.7.7.2 to 26.7.8.1; psram.ignore_not_found set to false, causing boot failure if PSRAM is absent.
Audio resampler and memory reconfiguration
Integrations/ESPHome/Core.yaml
Introduces separate announcement_resampling_speaker and media_resampling_speaker resampler components, sets sendspin_hub.task_stack_in_psram to false, removes explicit decode_memory: internal on sendspin source, increases audio_http buffer sizes, and rewires the announcement pipeline's speaker to announcement_resampling_speaker.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: bharvey88

Poem

A rabbit hops through YAML fields at night,
Splitting streams of sound just right—
Announcements here, media there,
PSRAM now demands its share.
Buffers grow, the stacks stay grounded,
Firmware bumped, and boot resounded! 🐇🎧

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the change, but it is too vague to clearly describe the buffering and PSRAM/audio pipeline updates. Use a more specific title, such as "Adjust ESPHome buffering and PSRAM handling" or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Buffering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@TrevorSchirmer TrevorSchirmer merged commit 86cf252 into beta Jul 8, 2026
8 checks passed
@TrevorSchirmer TrevorSchirmer deleted the Buffering branch July 8, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants