Consolidate http_request block into Core.yaml#102
Conversation
The http_request component config (verify_ssl + the OTA-download buffer sizes buffer_size_rx/tx) was duplicated identically across MSR-1.yaml, MSR-1_BLE.yaml, and MSR-1_Factory.yaml. Move it to Core.yaml so there is one source of truth; the ota/update http_request PLATFORMS stay in the variants and use the shared component. No compiled-output change; does not publish. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
WalkthroughESPHome HTTP request TLS verification and buffer sizes are centralized in ChangesESPHome HTTP configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Version: 26.7.9.1 (no change — no-publish consolidation)
What does this implement/fix?
Moves the
http_request:component config —verify_sslplus the OTA-downloadbuffer_size_rx: 5120/buffer_size_tx: 2048(sized for GitHub release-asset headers/URLs) — intoCore.yaml, since it was duplicated identically acrossMSR-1.yaml,MSR-1_BLE.yaml, andMSR-1_Factory.yaml.One source of truth for the buffer sizes. The
ota:andupdate:platforms that usehttp_requeststay in the variants (they reference the shared component). Compiled output is unchanged.Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
🤖 Generated with Claude Code
Summary by CodeRabbit