Skip to content

Consolidate http_request block into Core.yaml#102

Merged
bharvey88 merged 1 commit into
betafrom
consolidate/http-request
Jul 9, 2026
Merged

Consolidate http_request block into Core.yaml#102
bharvey88 merged 1 commit into
betafrom
consolidate/http-request

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Version: 26.7.9.1 (no change — no-publish consolidation)

What does this implement/fix?

Moves the http_request: component config — verify_ssl plus the OTA-download buffer_size_rx: 5120 / buffer_size_tx: 2048 (sized for GitHub release-asset headers/URLs) — into Core.yaml, since it was duplicated identically across MSR-1.yaml, MSR-1_BLE.yaml, and MSR-1_Factory.yaml.

One source of truth for the buffer sizes. The ota: and update: platforms that use http_request stay in the variants (they reference the shared component). Compiled output is unchanged.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability for ESPHome HTTP downloads by enabling stricter SSL verification and larger request buffers in the core configuration.
    • Removed custom HTTP request tuning from several device-specific configurations so they now use the default behavior.

The http_request component config (verify_ssl + the OTA-download buffer
sizes buffer_size_rx/tx) was duplicated identically across MSR-1.yaml,
MSR-1_BLE.yaml, and MSR-1_Factory.yaml. Move it to Core.yaml so there is
one source of truth; the ota/update http_request PLATFORMS stay in the
variants and use the shared component.

No compiled-output change; does not publish.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: daa73b84-b1d6-439e-a253-d1bf4e39f404

📥 Commits

Reviewing files that changed from the base of the PR and between bd24876 and 4be81c3.

📒 Files selected for processing (4)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/MSR-1.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml
  • Integrations/ESPHome/MSR-1_Factory.yaml
💤 Files with no reviewable changes (3)
  • Integrations/ESPHome/MSR-1.yaml
  • Integrations/ESPHome/MSR-1_BLE.yaml
  • Integrations/ESPHome/MSR-1_Factory.yaml

Walkthrough

ESPHome HTTP request TLS verification and buffer sizes are centralized in Core.yaml. The same settings are removed from the MSR-1, BLE, and Factory device configurations.

Changes

ESPHome HTTP configuration

Layer / File(s) Summary
Shared HTTP request configuration
Integrations/ESPHome/Core.yaml
Adds http_request settings for TLS verification and enlarged receive/transmit buffers.
Device configuration cleanup
Integrations/ESPHome/MSR-1.yaml, Integrations/ESPHome/MSR-1_BLE.yaml, Integrations/ESPHome/MSR-1_Factory.yaml
Removes duplicated device-level http_request settings while retaining the surrounding configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit hops through YAML bright,
Central buffers set just right.
TLS guards each winding trail,
Three old blocks now leave no tale.
OTA paths can breathe and run—
“Thump!” says Bun, “the cleanup’s done!”

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: centralizing the duplicated http_request configuration into Core.yaml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch consolidate/http-request

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bharvey88 bharvey88 merged commit 3736a18 into beta Jul 9, 2026
11 checks passed
@bharvey88 bharvey88 deleted the consolidate/http-request branch July 9, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant