Skip to content

Point MSR-1 installer at the factory image (restores Wi-Fi setup step)#16

Merged
bharvey88 merged 1 commit into
mainfrom
fix/msr1-factory-image
Jul 10, 2026
Merged

Point MSR-1 installer at the factory image (restores Wi-Fi setup step)#16
bharvey88 merged 1 commit into
mainfrom
fix/msr1-factory-image

Conversation

@bharvey88

Copy link
Copy Markdown
Collaborator

What does this change?

Fixes MSR-1 first-flash: the installer now flashes the factory image (with Improv-Serial), so esp-web-tools offers Wi-Fi setup over USB.

MSR-1's PR #97 (merged 2026-07-10) repurposed firmware/ as the end-user OTA image (MSR-1.yaml, no improv_serial) and moved the first-flash factory image (MSR-1_Factory.yaml, has improv) to firmware-factory/. The installer still pointed at firmware/, so it flashed the improv-less OTA build and the browser Wi-Fi step never appeared.

  • msr-1 stable firmware → firmware-factory/manifest.json (26.7.9.1, CORS-open, verified live).
  • The Add YAML view/download to device pages #3 config viewer already points at MSR-1_Factory.yaml, so it stays consistent — no change there.

Notes:

  • This is the first device restructured by the unified-firmware rollout. As other devices get the same treatment, each will need the same firmware/firmware-factory/ switch in the registry.
  • CI can't catch this — both URLs return 200, so the validator's HEAD check passes; the "wrong image, no improv" only surfaces on a real flash.

Checklist

  • Playwright tests pass locally (cd tests && npx playwright test) (19 passed, 1 intentional skip)
  • Any new runtime file/dir is added to the cp list in .github/workflows/pages.yml (n/a: devices.json data only)
  • No new build step, framework, or runtime CDN dependency
  • If devices.json changed: python scripts/validate_registry.py passes (Registry OK — all manifests + config URLs 200)

🤖 Generated with Claude Code

MSR-1's PR #97 (merged 2026-07-10) repurposed firmware/ as the end-user OTA
image (MSR-1.yaml, no improv_serial) and moved the first-flash factory image
(MSR-1_Factory.yaml, has improv) to firmware-factory/. The web installer must
flash the factory image so esp-web-tools can offer Wi-Fi setup over USB
(Improv-Serial), so point MSR-1's stable manifest at firmware-factory/manifest.json.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@bharvey88 bharvey88 merged commit c46bc84 into main Jul 10, 2026
2 checks passed
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/msr1-factory-image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant