Point MSR-1 installer at the factory image (restores Wi-Fi setup step)#16
Merged
Conversation
MSR-1's PR #97 (merged 2026-07-10) repurposed firmware/ as the end-user OTA image (MSR-1.yaml, no improv_serial) and moved the first-flash factory image (MSR-1_Factory.yaml, has improv) to firmware-factory/. The web installer must flash the factory image so esp-web-tools can offer Wi-Fi setup over USB (Improv-Serial), so point MSR-1's stable manifest at firmware-factory/manifest.json. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes MSR-1 first-flash: the installer now flashes the factory image (with Improv-Serial), so esp-web-tools offers Wi-Fi setup over USB.
MSR-1's PR #97 (merged 2026-07-10) repurposed
firmware/as the end-user OTA image (MSR-1.yaml, noimprov_serial) and moved the first-flash factory image (MSR-1_Factory.yaml, has improv) tofirmware-factory/. The installer still pointed atfirmware/, so it flashed the improv-less OTA build and the browser Wi-Fi step never appeared.msr-1stable firmware →firmware-factory/manifest.json(26.7.9.1, CORS-open, verified live).MSR-1_Factory.yaml, so it stays consistent — no change there.Notes:
firmware/→firmware-factory/switch in the registry.Checklist
cd tests && npx playwright test) (19 passed, 1 intentional skip)cplist in.github/workflows/pages.yml(n/a:devices.jsondata only)devices.jsonchanged:python scripts/validate_registry.pypasses (Registry OK — all manifests + config URLs 200)🤖 Generated with Claude Code