Improve model viewer on mobile scaling#2
Open
RealThe3D wants to merge 2 commits into
Open
Conversation
Member
|
Odd, I wonder what I fucked up during copying. The "old" style of guide publishing used by AE2 had this correct I think (at least I did test it on mobile) Not super happy about the device pixel ratio clamping to 2 though 😓 No one's gonna understand those magic numbers going forward. |
Author
|
Fair point, I assumed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model viewer is currently scaled too high for those on mobile devices. This PR attempts to make the width of the model viewer fit within the dimensions of a mobile device (mostly smartphones in portrait mode).
Before:
After:
This PR additionally gets rid of the X-axis overflow of the article guides on Desktop screens since the widths are adjusted accordingly.